Commit 1bbf2083 authored Aug 05, 2009 by Darren Hart Committed by Ingo Molnar Aug 06, 2009

rtmutex: Avoid deadlock in rt_mutex_start_proxy_lock()



In the event of a lock steal or owner died,
rt_mutex_start_proxy_lock() will give the rt_mutex to the
waiting task, but it fails to release the wait_lock. This leads
to subsequent deadlocks when other tasks try to acquire the
rt_mutex.

I also removed a few extra blank lines that really spaced this
routine out. I must have been high on the \n when I wrote this
originally...

Signed-off-by: Darren Hart <dvhltc@us.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Dinakar Guniguntala <dino@in.ibm.com>
Cc: John Stultz <johnstul@linux.vnet.ibm.com>
LKML-Reference: <4A79D7F1.4000405@us.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 90bc1a65

kernel/rtmutex.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -1039,16 +1039,14 @@ int rt_mutex_start_proxy_lock(struct rt_mutex *lock,
		if (!rt_mutex_owner(lock) \|\| try_to_steal_lock(lock, task)) {
		/* We got the lock for task. */
		debug_rt_mutex_lock(lock);

		rt_mutex_set_owner(lock, task, 0);

		spin_unlock(&lock->wait_lock);
		rt_mutex_deadlock_account_lock(lock, task);
		return 1;
		}

		ret = task_blocks_on_rt_mutex(lock, waiter, task, detect_deadlock);


		if (ret && !waiter->task) {
		/*
		* Reset the return value. We might have

Admin message