sparc32: fix sparse warnings in leon_smp.c (1bbc9060) · Commits · 戴 / test

Fix following warnings: leon_smp.c:133:6: warning: symbol 'leon_smp_setbroadcast' was not declared. Should it be static? leon_smp.c:151:14: warning: symbol 'leon_smp_getbroadcast' was not declared. Should it be static? leon_smp.c:269:6: warning: symbol 'leon_irq_rotate' was not declared. Should it be static? leon_smp.c:355:6: warning: symbol 'leonsmp_ipi_interrupt' was not declared. Should it be static? leon_smp.c:457:6: warning: symbol 'leon_cross_call_irq' was not declared. Should it be static? Add static. Remove unused functions. Signed-off-by:

Sam Ravnborg <sam@ravnborg.org> Cc: Daniel Hellstrom <daniel@gaisler.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

arch/sparc/kernel/kernel.h

+2 −0

Original line number	Diff line number	Diff line
		@@ -81,6 +81,8 @@ void smp4d_percpu_timer_interrupt(struct pt_regs *regs);
		/* leon_smp.c */
		void leon_cpu_pre_starting(void *arg);
		void leon_cpu_pre_online(void *arg);
		void leonsmp_ipi_interrupt(void);
		void leon_cross_call_irq(void);

		/* head_32.S */
		extern unsigned int t_nmi[];

arch/sparc/kernel/leon_smp.c

+1 −12

Original line number	Diff line number	Diff line
		@@ -130,7 +130,7 @@ void leon_configure_cache_smp(void)
		local_ops->tlb_all();
		}

		void leon_smp_setbroadcast(unsigned int mask)
		static void leon_smp_setbroadcast(unsigned int mask)
		{
		int broadcast =
		((LEON3_BYPASS_LOAD_PA(&(leon3_irqctrl_regs->mpstatus)) >>
		@@ -148,13 +148,6 @@ void leon_smp_setbroadcast(unsigned int mask)
		LEON_BYPASS_STORE_PA(&(leon3_irqctrl_regs->mpbroadcast), mask);
		}

		unsigned int leon_smp_getbroadcast(void)
		{
		unsigned int mask;
		mask = LEON_BYPASS_LOAD_PA(&(leon3_irqctrl_regs->mpbroadcast));
		return mask;
		}

		int leon_smp_nrcpus(void)
		{
		int nrcpu =
		@@ -266,10 +259,6 @@ void __init leon_smp_done(void)

		}

		void leon_irq_rotate(int cpu)
		{
		}

		struct leon_ipi_work {
		int single;
		int msk;

Admin message