Commit 1ba51a7c authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

ACPI / PCI / PM: Rework acpi_pci_propagate_wakeup() 



The acpi_pci_propagate_wakeup() routine is there to handle cases in
which PCI bridges (or PCIe ports) are expected to signal wakeup
for devices below them, but currently it doesn't do that correctly.

The problem is that acpi_pci_propagate_wakeup() uses
acpi_pm_set_device_wakeup() for bridges and if that routine is
called for multiple times to disable wakeup for the same device,
it will disable it on the first invocation and the next calls
will have no effect (it works analogously when called to enable
wakeup, but that is not a problem).

Now, say acpi_pci_propagate_wakeup() has been called for two
different devices under the same bridge and it has called
acpi_pm_set_device_wakeup() for that bridge each time.  The
bridge is now enabled to generate wakeup signals.  Next,
suppose that one of the devices below it resumes and
acpi_pci_propagate_wakeup() is called to disable wakeup for that
device.  It will then call acpi_pm_set_device_wakeup() for the bridge
and that will effectively disable remote wakeup for all devices under
it even though some of them may still be suspended and remote wakeup
may be expected to work for them.

To address this (arguably theoretical) issue, allow
wakeup.enable_count under struct acpi_device to grow beyond 1 in
certain situations.  In particular, allow that to happen in
acpi_pci_propagate_wakeup() when wakeup is enabled or disabled
for PCI bridges, so that wakeup is actually disabled for the
bridge when all devices under it resume and not when just one
of them does that.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 99d8845e

drivers/acpi/device_pm.c

+50 −22
Original line number Diff line number Diff line
@@ -684,19 +684,8 @@ static void acpi_pm_notify_work_func(struct acpi_device_wakeup_context *context) 


static DEFINE_MUTEX(acpi_wakeup_lock);



/**

 * acpi_device_wakeup_enable - Enable wakeup functionality for device.

 * @adev: ACPI device to enable wakeup functionality for.

 * @target_state: State the system is transitioning into.

 *

 * Enable the GPE associated with @adev so that it can generate wakeup signals

 * for the device in response to external (remote) events and enable wakeup

 * power for it.

 *

 * Callers must ensure that @adev is a valid ACPI device node before executing

 * this function.

 */

static int acpi_device_wakeup_enable(struct acpi_device *adev, u32 target_state)

static int __acpi_device_wakeup_enable(struct acpi_device *adev,

				       u32 target_state, int max_count)

{

	struct acpi_device_wakeup *wakeup = &adev->wakeup;

	acpi_status status;
@@ -704,9 +693,12 @@ static int acpi_device_wakeup_enable(struct acpi_device *adev, u32 target_state) 


	mutex_lock(&acpi_wakeup_lock);



	if (wakeup->enable_count > 0)

	if (wakeup->enable_count >= max_count)

		goto out;



	if (wakeup->enable_count > 0)

		goto inc;



	error = acpi_enable_wakeup_device_power(adev, target_state);

	if (error)

		goto out;
@@ -718,6 +710,7 @@ static int acpi_device_wakeup_enable(struct acpi_device *adev, u32 target_state) 
		goto out;

	}



inc:

	wakeup->enable_count++;



out:
@@ -725,6 +718,23 @@ out: 
	return error;

}



/**

 * acpi_device_wakeup_enable - Enable wakeup functionality for device.

 * @adev: ACPI device to enable wakeup functionality for.

 * @target_state: State the system is transitioning into.

 *

 * Enable the GPE associated with @adev so that it can generate wakeup signals

 * for the device in response to external (remote) events and enable wakeup

 * power for it.

 *

 * Callers must ensure that @adev is a valid ACPI device node before executing

 * this function.

 */

static int acpi_device_wakeup_enable(struct acpi_device *adev, u32 target_state)

{

	return __acpi_device_wakeup_enable(adev, target_state, 1);

}



/**

 * acpi_device_wakeup_disable - Disable wakeup functionality for device.

 * @adev: ACPI device to disable wakeup functionality for.
@@ -752,12 +762,8 @@ out: 
	mutex_unlock(&acpi_wakeup_lock);

}



/**

 * acpi_pm_set_device_wakeup - Enable/disable remote wakeup for given device.

 * @dev: Device to enable/disable to generate wakeup events.

 * @enable: Whether to enable or disable the wakeup functionality.

 */

int acpi_pm_set_device_wakeup(struct device *dev, bool enable)

static int __acpi_pm_set_device_wakeup(struct device *dev, bool enable,

				       int max_count)

{

	struct acpi_device *adev;

	int error;
@@ -777,13 +783,35 @@ int acpi_pm_set_device_wakeup(struct device *dev, bool enable) 
		return 0;

	}



	error = acpi_device_wakeup_enable(adev, acpi_target_system_state());

	error = __acpi_device_wakeup_enable(adev, acpi_target_system_state(),

					    max_count);

	if (!error)

		dev_dbg(dev, "Wakeup enabled by ACPI\n");



	return error;

}

EXPORT_SYMBOL(acpi_pm_set_device_wakeup);



/**

 * acpi_pm_set_device_wakeup - Enable/disable remote wakeup for given device.

 * @dev: Device to enable/disable to generate wakeup events.

 * @enable: Whether to enable or disable the wakeup functionality.

 */

int acpi_pm_set_device_wakeup(struct device *dev, bool enable)

{

	return __acpi_pm_set_device_wakeup(dev, enable, 1);

}

EXPORT_SYMBOL_GPL(acpi_pm_set_device_wakeup);



/**

 * acpi_pm_set_bridge_wakeup - Enable/disable remote wakeup for given bridge.

 * @dev: Bridge device to enable/disable to generate wakeup events.

 * @enable: Whether to enable or disable the wakeup functionality.

 */

int acpi_pm_set_bridge_wakeup(struct device *dev, bool enable)

{

	return __acpi_pm_set_device_wakeup(dev, enable, INT_MAX);

}

EXPORT_SYMBOL_GPL(acpi_pm_set_bridge_wakeup);



/**

 * acpi_dev_pm_low_power - Put ACPI device into a low-power state.

drivers/pci/pci-acpi.c

+2 −2
Original line number Diff line number Diff line
@@ -573,7 +573,7 @@ static int acpi_pci_propagate_wakeup(struct pci_bus *bus, bool enable) 
{

	while (bus->parent) {

		if (acpi_pm_device_can_wakeup(&bus->self->dev))

			return acpi_pm_set_device_wakeup(&bus->self->dev, enable);

			return acpi_pm_set_bridge_wakeup(&bus->self->dev, enable);



		bus = bus->parent;

	}
@@ -581,7 +581,7 @@ static int acpi_pci_propagate_wakeup(struct pci_bus *bus, bool enable) 
	/* We have reached the root bus. */

	if (bus->bridge) {

		if (acpi_pm_device_can_wakeup(bus->bridge))

			return acpi_pm_set_device_wakeup(bus->bridge, enable);

			return acpi_pm_set_bridge_wakeup(bus->bridge, enable);

	}

	return 0;

}

include/acpi/acpi_bus.h

+5 −0
Original line number Diff line number Diff line
@@ -606,6 +606,7 @@ acpi_status acpi_remove_pm_notifier(struct acpi_device *adev); 
bool acpi_pm_device_can_wakeup(struct device *dev);

int acpi_pm_device_sleep_state(struct device *, int *, int);

int acpi_pm_set_device_wakeup(struct device *dev, bool enable);

int acpi_pm_set_bridge_wakeup(struct device *dev, bool enable);

#else

static inline void acpi_pm_wakeup_event(struct device *dev)

{
@@ -636,6 +637,10 @@ static inline int acpi_pm_set_device_wakeup(struct device *dev, bool enable) 
{

	return -ENODEV;

}

static inline int acpi_pm_set_bridge_wakeup(struct device *dev, bool enable)

{

	return -ENODEV;

}

#endif



#ifdef CONFIG_ACPI_SLEEP

CRA Git | Maintained and supported by SUSTech CRA and CCSE