Commit 1ba3e023 authored Dec 10, 2018 by Guenter Roeck

hwmon: (ad7314) Use permission specific SENSOR[_DEVICE]_ATTR variants

Use SENSOR[_DEVICE]_ATTR[_2]_{RO,RW,WO} to simplify the source code,
to improve readbility, and to reduce the chance of inconsistencies.

Also replace any remaining S_<PERMS> in the driver with octal values.

The conversion was done automatically with coccinelle. The semantic patches
and the scripts used to generate this commit log are available at
https://github.com/groeck/coccinelle-patches/hwmon/

.

This patch does not introduce functional changes. It was verified by
compiling the old and new files and comparing text and data sizes.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 419eeabc

drivers/hwmon/ad7314.c

+4 −5

Original line number	Diff line number	Diff line
		@@ -53,7 +53,7 @@ static int ad7314_spi_read(struct ad7314_data *chip)
		return be16_to_cpu(chip->rx);
		}

		static ssize_t ad7314_show_temperature(struct device *dev,
		static ssize_t ad7314_temperature_show(struct device *dev,
		struct device_attribute *attr,
		char *buf)
		{
		@@ -87,8 +87,7 @@ static ssize_t ad7314_show_temperature(struct device *dev,
		}
		}

		static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO,
		ad7314_show_temperature, NULL, 0);
		static SENSOR_DEVICE_ATTR_RO(temp1_input, ad7314_temperature, 0);

		static struct attribute *ad7314_attrs[] = {
		&sensor_dev_attr_temp1_input.dev_attr.attr,

Admin message