Commit 1b9598c8 authored Mar 01, 2019 by Luis R. Rodriguez Committed by Darrick J. Wong Mar 01, 2019

xfs: fix reporting supported extra file attributes for statx()



statx(2) notes that any attribute that is not indicated as supported by
stx_attributes_mask has no usable value. Commit 5f955f26 ("xfs: report
crtime and attribute flags to statx") added support for informing userspace
of extra file attributes but forgot to list these flags as supported
making reporting them rather useless for the pedantic userspace author.

$ git describe --contains 5f955f26
v4.11-rc6~5^2^2~2

Fixes: 5f955f26 ("xfs: report crtime and attribute flags to statx")
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
[darrick: add a comment reminding people to keep attributes_mask up to date]
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

parent 3d129e1b

fs/xfs/xfs_iops.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -531,6 +531,10 @@ xfs_vn_getattr(
		}
		}

		/*
		* Note: If you add another clause to set an attribute flag, please
		* update attributes_mask below.
		*/
		if (ip->i_d.di_flags & XFS_DIFLAG_IMMUTABLE)
		stat->attributes \|= STATX_ATTR_IMMUTABLE;
		if (ip->i_d.di_flags & XFS_DIFLAG_APPEND)
		@@ -538,6 +542,10 @@ xfs_vn_getattr(
		if (ip->i_d.di_flags & XFS_DIFLAG_NODUMP)
		stat->attributes \|= STATX_ATTR_NODUMP;

		stat->attributes_mask \|= (STATX_ATTR_IMMUTABLE \|
		STATX_ATTR_APPEND \|
		STATX_ATTR_NODUMP);

		switch (inode->i_mode & S_IFMT) {
		case S_IFBLK:
		case S_IFCHR:

Admin message