selftests: forwarding: multipath_eval(): Improve style (1b86fa3b) · Commits · 戴 / test

- Change the indentation of the function body from 7 spaces to one tab. - Move initialization of weights_ratio up so that it can be referenced from the error message about packet difference being zero. - Move |'s consistently to continuation line, which reindent. Signed-off-by:

Petr Machata <petrm@mellanox.com> Reviewed-by:

Ido Schimmel <idosch@mellanox.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

tools/testing/selftests/net/forwarding/lib.sh

+39 −35

Original line number	Diff line number	Diff line
		@@ -568,6 +568,14 @@ multipath_eval()

		RET=0

		if [[ "$weight_rp12" -gt "$weight_rp13" ]]; then
		weights_ratio=$(echo "scale=2; $weight_rp12 / $weight_rp13" \
		\| bc -l)
		else
		weights_ratio=$(echo "scale=2; $weight_rp13 / $weight_rp12" \
		\| bc -l)
		fi

		if [[ "$packets_rp12" -eq "0" \|\| "$packets_rp13" -eq "0" ]]; then
		check_err 1 "Packet difference is 0"
		log_test "Multipath"
		@@ -576,15 +584,11 @@ multipath_eval()
		fi

		if [[ "$weight_rp12" -gt "$weight_rp13" ]]; then
		weights_ratio=$(echo "scale=2; $weight_rp12 / $weight_rp13" \
		\| bc -l)
		packets_ratio=$(echo "scale=2; $packets_rp12 / $packets_rp13" \
		\| bc -l)
		else
		weights_ratio=$(echo "scale=2; $weight_rp13 / $weight_rp12" \| \
		bc -l)
		packets_ratio=$(echo "scale=2; $packets_rp13 / $packets_rp12" \| \
		bc -l)
		packets_ratio=$(echo "scale=2; $packets_rp13 / $packets_rp12" \
		\| bc -l)
		fi

		diff=$(echo $weights_ratio - $packets_ratio \| bc -l)

Admin message