Commit 1b732396 authored Nov 27, 2009 by Csaba Henk Committed by Miklos Szeredi Nov 27, 2009

fuse: reject O_DIRECT flag also in fuse_create



The comment in fuse_open about O_DIRECT:

  "VFS checks this, but only _after_ ->open()"

also holds for fuse_create, however, the same kind of check was missing there.

As an impact of this bug, open(newfile, O_RDWR|O_CREAT|O_DIRECT) fails, but a
stub newfile will remain if the fuse server handled the implied FUSE_CREATE
request appropriately.

Other impact: in the above situation ima_file_free() will complain to open/free
imbalance if CONFIG_IMA is set.

Signed-off-by: Csaba Henk <csaba@gluster.com>
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Cc: Harshavardhana <harsha@gluster.com>
Cc: stable@kernel.org

parent a8a8a669

fs/fuse/dir.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -385,6 +385,9 @@ static int fuse_create_open(struct inode dir, struct dentry entry, int mode,
		if (fc->no_create)
		return -ENOSYS;

		if (flags & O_DIRECT)
		return -EINVAL;

		forget_req = fuse_get_req(fc);
		if (IS_ERR(forget_req))
		return PTR_ERR(forget_req);

Admin message