Commit 1b72d432 authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

tick: Remove outgoing CPU from broadcast masks 



Valentin reported that unplugging a CPU occasionally results in a warning
in the tick broadcast code which is triggered when an offline CPU is in the
broadcast mask.

This happens because the outgoing CPU is not removing itself from the
broadcast masks, especially not from the broadcast_force_mask. The removal
happens on the control CPU after the outgoing CPU is dead. It's a long
standing issue, but the warning is harmless.

Rework the hotplug mechanism so that the outgoing CPU removes itself from
the broadcast masks after disabling interrupts and removing itself from the
online mask.

Reported-by: default avatarValentin Schneider <valentin.schneider@arm.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Tested-by: default avatarValentin Schneider <valentin.schneider@arm.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1903211540180.1784@nanos.tec.linutronix.de
parent e1e41b6c

include/linux/tick.h

+6 −0
Original line number Diff line number Diff line
@@ -68,6 +68,12 @@ extern void tick_broadcast_control(enum tick_broadcast_mode mode); 
static inline void tick_broadcast_control(enum tick_broadcast_mode mode) { }

#endif /* BROADCAST */



#if defined(CONFIG_GENERIC_CLOCKEVENTS_BROADCAST) && defined(CONFIG_HOTPLUG_CPU)

extern void tick_offline_cpu(unsigned int cpu);

#else

static inline void tick_offline_cpu(unsigned int cpu) { }

#endif



#ifdef CONFIG_GENERIC_CLOCKEVENTS

extern int tick_broadcast_oneshot_control(enum tick_broadcast_state state);

#else

kernel/cpu.c

+2 −0
Original line number Diff line number Diff line
@@ -844,6 +844,8 @@ static int take_cpu_down(void *_param) 


	/* Give up timekeeping duties */

	tick_handover_do_timer();

	/* Remove CPU from timer broadcasting */

	tick_offline_cpu(cpu);

	/* Park the stopper thread */

	stop_machine_park(cpu);

	return 0;

kernel/time/clockevents.c

+16 −2
Original line number Diff line number Diff line
@@ -611,6 +611,22 @@ void clockevents_resume(void) 
}



#ifdef CONFIG_HOTPLUG_CPU



# ifdef CONFIG_GENERIC_CLOCKEVENTS_BROADCAST

/**

 * tick_offline_cpu - Take CPU out of the broadcast mechanism

 * @cpu:	The outgoing CPU

 *

 * Called on the outgoing CPU after it took itself offline.

 */

void tick_offline_cpu(unsigned int cpu)

{

	raw_spin_lock(&clockevents_lock);

	tick_broadcast_offline(cpu);

	raw_spin_unlock(&clockevents_lock);

}

# endif



/**

 * tick_cleanup_dead_cpu - Cleanup the tick and clockevents of a dead cpu

 */
@@ -621,8 +637,6 @@ void tick_cleanup_dead_cpu(int cpu) 


	raw_spin_lock_irqsave(&clockevents_lock, flags);



	tick_shutdown_broadcast_oneshot(cpu);

	tick_shutdown_broadcast(cpu);

	tick_shutdown(cpu);

	/*

	 * Unregister the clock event devices which were

kernel/time/tick-broadcast.c

+19 −21
Original line number Diff line number Diff line
@@ -36,10 +36,12 @@ static __cacheline_aligned_in_smp DEFINE_RAW_SPINLOCK(tick_broadcast_lock); 
static void tick_broadcast_setup_oneshot(struct clock_event_device *bc);

static void tick_broadcast_clear_oneshot(int cpu);

static void tick_resume_broadcast_oneshot(struct clock_event_device *bc);

static void tick_broadcast_oneshot_offline(unsigned int cpu);

#else

static inline void tick_broadcast_setup_oneshot(struct clock_event_device *bc) { BUG(); }

static inline void tick_broadcast_clear_oneshot(int cpu) { }

static inline void tick_resume_broadcast_oneshot(struct clock_event_device *bc) { }

static inline void tick_broadcast_oneshot_offline(unsigned int cpu) { }

#endif



/*
@@ -433,27 +435,29 @@ void tick_set_periodic_handler(struct clock_event_device *dev, int broadcast) 
}



#ifdef CONFIG_HOTPLUG_CPU

/*

 * Remove a CPU from broadcasting

 */

void tick_shutdown_broadcast(unsigned int cpu)

static void tick_shutdown_broadcast(void)

{

	struct clock_event_device *bc;

	unsigned long flags;



	raw_spin_lock_irqsave(&tick_broadcast_lock, flags);



	bc = tick_broadcast_device.evtdev;

	cpumask_clear_cpu(cpu, tick_broadcast_mask);

	cpumask_clear_cpu(cpu, tick_broadcast_on);

	struct clock_event_device *bc = tick_broadcast_device.evtdev;



	if (tick_broadcast_device.mode == TICKDEV_MODE_PERIODIC) {

		if (bc && cpumask_empty(tick_broadcast_mask))

			clockevents_shutdown(bc);

	}

}



	raw_spin_unlock_irqrestore(&tick_broadcast_lock, flags);

/*

 * Remove a CPU from broadcasting

 */

void tick_broadcast_offline(unsigned int cpu)

{

	raw_spin_lock(&tick_broadcast_lock);

	cpumask_clear_cpu(cpu, tick_broadcast_mask);

	cpumask_clear_cpu(cpu, tick_broadcast_on);

	tick_broadcast_oneshot_offline(cpu);

	tick_shutdown_broadcast();

	raw_spin_unlock(&tick_broadcast_lock);

}



#endif



void tick_suspend_broadcast(void)
@@ -950,14 +954,10 @@ void hotplug_cpu__broadcast_tick_pull(int deadcpu) 
}



/*

 * Remove a dead CPU from broadcasting

 * Remove a dying CPU from broadcasting

 */

void tick_shutdown_broadcast_oneshot(unsigned int cpu)

static void tick_broadcast_oneshot_offline(unsigned int cpu)

{

	unsigned long flags;



	raw_spin_lock_irqsave(&tick_broadcast_lock, flags);



	/*

	 * Clear the broadcast masks for the dead cpu, but do not stop

	 * the broadcast device!
@@ -965,8 +965,6 @@ void tick_shutdown_broadcast_oneshot(unsigned int cpu) 
	cpumask_clear_cpu(cpu, tick_broadcast_oneshot_mask);

	cpumask_clear_cpu(cpu, tick_broadcast_pending_mask);

	cpumask_clear_cpu(cpu, tick_broadcast_force_mask);



	raw_spin_unlock_irqrestore(&tick_broadcast_lock, flags);

}

#endif

kernel/time/tick-internal.h

+6 −4
Original line number Diff line number Diff line
@@ -64,7 +64,6 @@ extern ssize_t sysfs_get_uname(const char *buf, char *dst, size_t cnt); 
extern int tick_device_uses_broadcast(struct clock_event_device *dev, int cpu);

extern void tick_install_broadcast_device(struct clock_event_device *dev);

extern int tick_is_broadcast_device(struct clock_event_device *dev);

extern void tick_shutdown_broadcast(unsigned int cpu);

extern void tick_suspend_broadcast(void);

extern void tick_resume_broadcast(void);

extern bool tick_resume_check_broadcast(void);
@@ -78,7 +77,6 @@ static inline void tick_install_broadcast_device(struct clock_event_device *dev) 
static inline int tick_is_broadcast_device(struct clock_event_device *dev) { return 0; }

static inline int tick_device_uses_broadcast(struct clock_event_device *dev, int cpu) { return 0; }

static inline void tick_do_periodic_broadcast(struct clock_event_device *d) { }

static inline void tick_shutdown_broadcast(unsigned int cpu) { }

static inline void tick_suspend_broadcast(void) { }

static inline void tick_resume_broadcast(void) { }

static inline bool tick_resume_check_broadcast(void) { return false; }
@@ -128,19 +126,23 @@ static inline int tick_check_oneshot_change(int allow_nohz) { return 0; } 
/* Functions related to oneshot broadcasting */

#if defined(CONFIG_GENERIC_CLOCKEVENTS_BROADCAST) && defined(CONFIG_TICK_ONESHOT)

extern void tick_broadcast_switch_to_oneshot(void);

extern void tick_shutdown_broadcast_oneshot(unsigned int cpu);

extern int tick_broadcast_oneshot_active(void);

extern void tick_check_oneshot_broadcast_this_cpu(void);

bool tick_broadcast_oneshot_available(void);

extern struct cpumask *tick_get_broadcast_oneshot_mask(void);

#else /* !(BROADCAST && ONESHOT): */

static inline void tick_broadcast_switch_to_oneshot(void) { }

static inline void tick_shutdown_broadcast_oneshot(unsigned int cpu) { }

static inline int tick_broadcast_oneshot_active(void) { return 0; }

static inline void tick_check_oneshot_broadcast_this_cpu(void) { }

static inline bool tick_broadcast_oneshot_available(void) { return tick_oneshot_possible(); }

#endif /* !(BROADCAST && ONESHOT) */



#if defined(CONFIG_GENERIC_CLOCKEVENTS_BROADCAST) && defined(CONFIG_HOTPLUG_CPU)

extern void tick_broadcast_offline(unsigned int cpu);

#else

static inline void tick_broadcast_offline(unsigned int cpu) { }

#endif



/* NO_HZ_FULL internal */

#ifdef CONFIG_NO_HZ_FULL

extern void tick_nohz_init(void);

CRA Git | Maintained and supported by SUSTech CRA and CCSE