Commit 1b5482e0 authored Dec 17, 2019 by Peter Ujfalusi Committed by Mauro Carvalho Chehab Feb 24, 2020

media: rcar_drif: Use dma_request_chan() instead dma_request_slave_channel()



dma_request_slave_channel() is a wrapper on top of dma_request_chan()
eating up the error code.

By using dma_request_chan() directly the driver can support deferred
probing against DMA.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

parent eee16d21

drivers/media/platform/rcar_drif.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -275,10 +275,10 @@ static int rcar_drif_alloc_dmachannels(struct rcar_drif_sdr *sdr)
		for_each_rcar_drif_channel(i, &sdr->cur_ch_mask) {
		struct rcar_drif *ch = sdr->ch[i];

		ch->dmach = dma_request_slave_channel(&ch->pdev->dev, "rx");
		if (!ch->dmach) {
		ch->dmach = dma_request_chan(&ch->pdev->dev, "rx");
		if (IS_ERR(ch->dmach)) {
		rdrif_err(sdr, "ch%u: dma channel req failed\n", i);
		ret = -ENODEV;
		ret = PTR_ERR(ch->dmach);
		goto dmach_error;
		}

Admin message