Commit 1b52e50f authored Sep 21, 2015 by Javier Martinez Canillas Committed by Lee Jones Oct 01, 2015

mfd: max77843: Fix max77843_chg_init() return on error



If i2c_new_dummy() fails in max77843_chg_init(), an PTR_ERR(NULL) is
returned which is 0. So the function was wrongly returning a success
value instead of an error code.

Cc: stable@vger.kernel.org # 4.1
Fixes: c7f585fe ("mfd: max77843: Add max77843 MFD driver core driver")
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

parent 47b91923

drivers/mfd/max77843.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -80,7 +80,7 @@ static int max77843_chg_init(struct max77693_dev *max77843)
		if (!max77843->i2c_chg) {
		dev_err(&max77843->i2c->dev,
		"Cannot allocate I2C device for Charger\n");
		return PTR_ERR(max77843->i2c_chg);
		return -ENODEV;
		}
		i2c_set_clientdata(max77843->i2c_chg, max77843);

Admin message