leds: pwm: Use pwm_get_args() where appropriate (1b50673d) · Commits · 戴 / test

The PWM framework has clarified the concept of reference PWM config (the platform dependent config retrieved from the DT or the PWM lookup table) and real PWM state. Use pwm_get_args() when the PWM user wants to retrieve this reference config and not the current state. This is part of the rework allowing the PWM framework to support hardware readout and expose real PWM state even when the PWM has just been requested (before the user calls pwm_config/enable/disable()). Signed-off-by:

Boris Brezillon <boris.brezillon@free-electrons.com> Acked-by:

Jacek Anaszewski <j.anaszewski@samsung.com> Signed-off-by:

Thierry Reding <thierry.reding@gmail.com>

drivers/leds/leds-pwm.c

+10 −1

Original line number	Diff line number	Diff line
		@@ -91,6 +91,7 @@ static int led_pwm_add(struct device dev, struct led_pwm_priv priv,
		struct led_pwm led, struct device_node child)
		{
		struct led_pwm_data *led_data = &priv->leds[priv->num_leds];
		struct pwm_args pargs;
		int ret;

		led_data->active_low = led->active_low;
		@@ -117,7 +118,15 @@ static int led_pwm_add(struct device dev, struct led_pwm_priv priv,
		else
		led_data->cdev.brightness_set_blocking = led_pwm_set_blocking;

		led_data->period = pwm_get_period(led_data->pwm);
		/*
		* FIXME: pwm_apply_args() should be removed when switching to the
		* atomic PWM API.
		*/
		pwm_apply_args(led_data->pwm);

		pwm_get_args(led_data->pwm, &pargs);

		led_data->period = pargs.period;
		if (!led_data->period && (led->pwm_period_ns > 0))
		led_data->period = led->pwm_period_ns;

Admin message