Unverified Commit 1b4fb70e authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Mark Brown
Browse files

ASoC: ti: davinci-mcasp: Handle missing required DT properties 



McASP needs three required properties to be usable for audio:
op-mode, tdm-slots and the serial-dir array.

Instead of probing the driver even without the needed information we should
make sure that all the parameters are provided for operation.

The fact that McASP can act as a GPIO controller for it's pins complicates
this a bit, but as a general rule we can:
- we fail the probe if McASP is not configured to be used as gpiochip
- we will not register the DAI (and PCM) if gpiochip is defined

Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/20201106072551.689-5-peter.ujfalusi@ti.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1125d925

sound/soc/ti/davinci-mcasp.c

+58 −19
Original line number Diff line number Diff line
@@ -83,6 +83,9 @@ struct davinci_mcasp { 
	struct snd_pcm_substream *substreams[2];

	unsigned int dai_fmt;



	/* Audio can not be enabled due to missing parameter(s) */

	bool	missing_audio_param;



	/* McASP specific data */

	int	tdm_slots;

	u32	tdm_mask[2];
@@ -1748,6 +1751,17 @@ err1: 
	return ret;

}



static bool davinci_mcasp_have_gpiochip(struct davinci_mcasp *mcasp)

{

#ifdef CONFIG_OF_GPIO

	if (mcasp->dev->of_node &&

	    of_property_read_bool(mcasp->dev->of_node, "gpio-controller"))

		return true;

#endif



	return false;

}



static int davinci_mcasp_get_config(struct davinci_mcasp *mcasp,

				    struct platform_device *pdev)

{
@@ -1772,8 +1786,12 @@ static int davinci_mcasp_get_config(struct davinci_mcasp *mcasp, 
		return -EINVAL;

	}



	if (of_property_read_u32(np, "op-mode", &val) == 0)

	if (of_property_read_u32(np, "op-mode", &val) == 0) {

		pdata->op_mode = val;

	} else {

		mcasp->missing_audio_param = true;

		goto out;

	}



	if (of_property_read_u32(np, "tdm-slots", &val) == 0) {

		if (val < 2 || val > 32) {
@@ -1782,6 +1800,9 @@ static int davinci_mcasp_get_config(struct davinci_mcasp *mcasp, 
		}



		pdata->tdm_slots = val;

	} else if (pdata->op_mode == DAVINCI_MCASP_IIS_MODE) {

		mcasp->missing_audio_param = true;

		goto out;

	}



	of_serial_dir32 = of_get_property(np, "serial-dir", &val);
@@ -1798,6 +1819,9 @@ static int davinci_mcasp_get_config(struct davinci_mcasp *mcasp, 


		pdata->num_serializer = val;

		pdata->serial_dir = of_serial_dir;

	} else {

		mcasp->missing_audio_param = true;

		goto out;

	}



	if (of_property_read_u32(np, "tx-num-evt", &val) == 0)
@@ -1823,6 +1847,16 @@ static int davinci_mcasp_get_config(struct davinci_mcasp *mcasp, 
out:

	mcasp->pdata = pdata;



	if (mcasp->missing_audio_param) {

		if (davinci_mcasp_have_gpiochip(mcasp)) {

			dev_dbg(&pdev->dev, "Missing DT parameter(s) for audio\n");

			return 0;

		}



		dev_err(&pdev->dev, "Insufficient DT parameter(s)\n");

		return -ENODEV;

	}



	mcasp->op_mode = pdata->op_mode;

	/* sanity check for tdm slots parameter */

	if (mcasp->op_mode == DAVINCI_MCASP_IIS_MODE) {
@@ -2072,7 +2106,7 @@ static const struct gpio_chip davinci_mcasp_template_chip = { 


static int davinci_mcasp_init_gpiochip(struct davinci_mcasp *mcasp)

{

	if (!of_property_read_bool(mcasp->dev->of_node, "gpio-controller"))

	if (!davinci_mcasp_have_gpiochip(mcasp))

		return 0;



	mcasp->gpio_chip = davinci_mcasp_template_chip;
@@ -2111,11 +2145,6 @@ static int davinci_mcasp_probe(struct platform_device *pdev) 
	if (!mcasp)

		return	-ENOMEM;



	mcasp->dev = &pdev->dev;

	ret = davinci_mcasp_get_config(mcasp, pdev);

	if (ret)

		return ret;



	mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mpu");

	if (!mem) {

		dev_warn(&pdev->dev,
@@ -2131,8 +2160,23 @@ static int davinci_mcasp_probe(struct platform_device *pdev) 
	if (IS_ERR(mcasp->base))

		return PTR_ERR(mcasp->base);



	dev_set_drvdata(&pdev->dev, mcasp);

	pm_runtime_enable(&pdev->dev);



	mcasp->dev = &pdev->dev;

	ret = davinci_mcasp_get_config(mcasp, pdev);

	if (ret)

		goto err;



	/* All PINS as McASP */

	pm_runtime_get_sync(mcasp->dev);

	mcasp_set_reg(mcasp, DAVINCI_MCASP_PFUNC_REG, 0x00000000);

	pm_runtime_put(mcasp->dev);



	/* Skip audio related setup code if the configuration is not adequat */

	if (mcasp->missing_audio_param)

		goto no_audio;



	irq = platform_get_irq_byname_optional(pdev, "common");

	if (irq > 0) {

		irq_name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_common",
@@ -2252,19 +2296,8 @@ static int davinci_mcasp_probe(struct platform_device *pdev) 
	if (ret)

		goto err;



	dev_set_drvdata(&pdev->dev, mcasp);



	mcasp_reparent_fck(pdev);



	/* All PINS as McASP */

	pm_runtime_get_sync(mcasp->dev);

	mcasp_set_reg(mcasp, DAVINCI_MCASP_PFUNC_REG, 0x00000000);

	pm_runtime_put(mcasp->dev);



	ret = davinci_mcasp_init_gpiochip(mcasp);

	if (ret)

		goto err;



	ret = devm_snd_soc_register_component(&pdev->dev, &davinci_mcasp_component,

					      &davinci_mcasp_dai[mcasp->op_mode], 1);
@@ -2294,8 +2327,14 @@ static int davinci_mcasp_probe(struct platform_device *pdev) 
		goto err;

	}



	return 0;

no_audio:

	ret = davinci_mcasp_init_gpiochip(mcasp);

	if (ret) {

		dev_err(&pdev->dev, "gpiochip registration failed: %d\n", ret);

		goto err;

	}



	return 0;

err:

	pm_runtime_disable(&pdev->dev);

	return ret;

CRA Git | Maintained and supported by SUSTech CRA and CCSE