Commit 1b44a6ae authored Mar 23, 2018 by Darrick J. Wong

xfs: record inode buf errors as a xref error in inobt scrubber



During the inode btree scrubs we try to confirm the freemask bits
against the inode records.  If the inode buffer read fails, this is a
cross-referencing error, not a corruption of the inode btree itself.
Use the xref_process_error call here.  Found via core.version middlebit
fuzz in xfs/415.

The userspace xfs_scrub program will try to repair outright corruptions
in the agi/inobt prior to phase 3 so that the inode scan will proceed.
If only a cross-referencing error is noted, the repair program defers
the repair attempt until it can check the other space metadata at least
once.

It is therefore essential that the inobt scrubber can correctly
distinguish between corruptions and "unable to cross-reference something
else with this inobt".

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>

parent 7e56d9ea

fs/xfs/scrub/ialloc.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -259,7 +259,8 @@ xfs_scrub_iallocbt_check_freemask(

		error = xfs_imap_to_bp(mp, bs->cur->bc_tp, &imap,
		&dip, &bp, 0, 0);
		if (!xfs_scrub_btree_process_error(bs->sc, bs->cur, 0, &error))
		if (!xfs_scrub_btree_xref_process_error(bs->sc, bs->cur, 0,
		&error))
		continue;

		/* Which inodes are free? */

Admin message