Commit 1b3d4200 authored by Luis R. Rodriguez's avatar Luis R. Rodriguez Committed by Ingo Molnar
Browse files

PCI: Add pci_iomap_wc() variants 



PCI BARs tell us whether prefetching is safe, but they don't say
anything about write combining (WC). WC changes ordering rules
and allows writes to be collapsed, so it's not safe in general
to use it on a prefetchable region.

Add pci_iomap_wc() and pci_iomap_wc_range() so drivers can take
advantage of write combining when they know it's safe.

On architectures that don't fully support WC, e.g., x86 without
PAT, drivers for legacy framebuffers may get some of the benefit
by using arch_phys_wc_add() in addition to pci_iomap_wc().  But
arch_phys_wc_add() is unreliable and should be avoided in
general.  On x86, it uses MTRRs, which are limited in number and
size, so the results will vary based on driver loading order.

The goals of adding pci_iomap_wc() are to:

- Give drivers an architecture-independent way to use WC so they can stop
  using interfaces like mtrr_add() (on x86, pci_iomap_wc() uses
  PAT when available).

- Move toward using _PAGE_CACHE_MODE_UC, not _PAGE_CACHE_MODE_UC_MINUS,
  on x86 on ioremap_nocache() (see de33c442 ("x86 PAT: fix
  performance drop for glx, use UC minus for ioremap(), ioremap_nocache()
  and pci_mmap_page_range()").

Signed-off-by: default avatarLuis R. Rodriguez <mcgrof@suse.com>
[ Move IORESOURCE_IO check up, space out statements for better readability. ]
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Acked-by: default avatarArnd Bergmann <arnd@arndb.de>
Cc: <roger.pau@citrix.com>
Cc: <syrjala@sci.fi>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Antonino Daplas <adaplas@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Davidlohr Bueso <dbueso@suse.de>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Roger Pau Monné <roger.pau@citrix.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Stefan Bader <stefan.bader@canonical.com>
Cc: Suresh Siddha <sbsiddha@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Toshi Kani <toshi.kani@hp.com>
Cc: Ville Syrjälä <syrjala@sci.fi>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: airlied@linux.ie
Cc: benh@kernel.crashing.org
Cc: dan.j.williams@intel.com
Cc: david.vrabel@citrix.com
Cc: jbeulich@suse.com
Cc: konrad.wilk@oracle.com
Cc: linux-arch@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org
Cc: linux-pci@vger.kernel.org
Cc: venkatesh.pallipadi@intel.com
Cc: vinod.koul@intel.com
Cc: xen-devel@lists.xensource.com
Link: http://lkml.kernel.org/r/1440443613-13696-6-git-send-email-mcgrof@do-not-panic.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent f3adccbd

include/asm-generic/pci_iomap.h

+14 −0
Original line number Diff line number Diff line
@@ -15,9 +15,13 @@ struct pci_dev; 
#ifdef CONFIG_PCI

/* Create a virtual mapping cookie for a PCI BAR (memory or IO) */

extern void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long max);

extern void __iomem *pci_iomap_wc(struct pci_dev *dev, int bar, unsigned long max);

extern void __iomem *pci_iomap_range(struct pci_dev *dev, int bar,

				     unsigned long offset,

				     unsigned long maxlen);

extern void __iomem *pci_iomap_wc_range(struct pci_dev *dev, int bar,

					unsigned long offset,

					unsigned long maxlen);

/* Create a virtual mapping cookie for a port on a given PCI device.

 * Do not call this directly, it exists to make it easier for architectures

 * to override */
@@ -34,12 +38,22 @@ static inline void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned lon 
	return NULL;

}



static inline void __iomem *pci_iomap_wc(struct pci_dev *dev, int bar, unsigned long max)

{

	return NULL;

}

static inline void __iomem *pci_iomap_range(struct pci_dev *dev, int bar,

					    unsigned long offset,

					    unsigned long maxlen)

{

	return NULL;

}

static inline void __iomem *pci_iomap_wc_range(struct pci_dev *dev, int bar,

					       unsigned long offset,

					       unsigned long maxlen)

{

	return NULL;

}

#endif



#endif /* __ASM_GENERIC_IO_H */

lib/pci_iomap.c

+66 −0
Original line number Diff line number Diff line
@@ -51,6 +51,51 @@ void __iomem *pci_iomap_range(struct pci_dev *dev, 
}

EXPORT_SYMBOL(pci_iomap_range);



/**

 * pci_iomap_wc_range - create a virtual WC mapping cookie for a PCI BAR

 * @dev: PCI device that owns the BAR

 * @bar: BAR number

 * @offset: map memory at the given offset in BAR

 * @maxlen: max length of the memory to map

 *

 * Using this function you will get a __iomem address to your device BAR.

 * You can access it using ioread*() and iowrite*(). These functions hide

 * the details if this is a MMIO or PIO address space and will just do what

 * you expect from them in the correct way. When possible write combining

 * is used.

 *

 * @maxlen specifies the maximum length to map. If you want to get access to

 * the complete BAR from offset to the end, pass %0 here.

 * */

void __iomem *pci_iomap_wc_range(struct pci_dev *dev,

				 int bar,

				 unsigned long offset,

				 unsigned long maxlen)

{

	resource_size_t start = pci_resource_start(dev, bar);

	resource_size_t len = pci_resource_len(dev, bar);

	unsigned long flags = pci_resource_flags(dev, bar);





	if (flags & IORESOURCE_IO)

		return NULL;



	if (len <= offset || !start)

		return NULL;



	len -= offset;

	start += offset;

	if (maxlen && len > maxlen)

		len = maxlen;



	if (flags & IORESOURCE_MEM)

		return ioremap_wc(start, len);



	/* What? */

	return NULL;

}

EXPORT_SYMBOL_GPL(pci_iomap_wc_range);



/**

 * pci_iomap - create a virtual mapping cookie for a PCI BAR

 * @dev: PCI device that owns the BAR
@@ -70,4 +115,25 @@ void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long maxlen) 
	return pci_iomap_range(dev, bar, 0, maxlen);

}

EXPORT_SYMBOL(pci_iomap);



/**

 * pci_iomap_wc - create a virtual WC mapping cookie for a PCI BAR

 * @dev: PCI device that owns the BAR

 * @bar: BAR number

 * @maxlen: length of the memory to map

 *

 * Using this function you will get a __iomem address to your device BAR.

 * You can access it using ioread*() and iowrite*(). These functions hide

 * the details if this is a MMIO or PIO address space and will just do what

 * you expect from them in the correct way. When possible write combining

 * is used.

 *

 * @maxlen specifies the maximum length to map. If you want to get access to

 * the complete BAR without checking for its length first, pass %0 here.

 * */

void __iomem *pci_iomap_wc(struct pci_dev *dev, int bar, unsigned long maxlen)

{

	return pci_iomap_wc_range(dev, bar, 0, maxlen);

}

EXPORT_SYMBOL_GPL(pci_iomap_wc);

#endif /* CONFIG_PCI */

CRA Git | Maintained and supported by SUSTech CRA and CCSE