Commit 1b061d92 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Al Viro
Browse files

rename the generic fsync implementations 



We don't name our generic fsync implementations very well currently.
The no-op implementation for in-memory filesystems currently is called
simple_sync_file which doesn't make too much sense to start with,
the the generic one for simple filesystems is called simple_fsync
which can lead to some confusion.

This patch renames the generic file fsync method to generic_file_fsync
to match the other generic_file_* routines it is supposed to be used
with, and the no-op implementation to noop_fsync to make it obvious
what to expect.  In addition add some documentation for both methods.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 7ea80859

arch/powerpc/platforms/cell/spufs/inode.c

+1 −1
Original line number Diff line number Diff line
@@ -251,7 +251,7 @@ const struct file_operations spufs_context_fops = { 
	.llseek		= dcache_dir_lseek,

	.read		= generic_read_dir,

	.readdir	= dcache_readdir,

	.fsync		= simple_sync_file,

	.fsync		= noop_fsync,

};

EXPORT_SYMBOL_GPL(spufs_context_fops);

fs/adfs/dir.c

+1 −1
Original line number Diff line number Diff line
@@ -197,7 +197,7 @@ const struct file_operations adfs_dir_operations = { 
	.read		= generic_read_dir,

	.llseek		= generic_file_llseek,

	.readdir	= adfs_readdir,

	.fsync		= simple_fsync,

	.fsync		= generic_file_fsync,

};



static int

fs/adfs/file.c

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ const struct file_operations adfs_file_operations = { 
	.read		= do_sync_read,

	.aio_read	= generic_file_aio_read,

	.mmap		= generic_file_mmap,

	.fsync		= simple_fsync,

	.fsync		= generic_file_fsync,

	.write		= do_sync_write,

	.aio_write	= generic_file_aio_write,

	.splice_read	= generic_file_splice_read,

fs/bfs/dir.c

+1 −1
Original line number Diff line number Diff line
@@ -78,7 +78,7 @@ static int bfs_readdir(struct file *f, void *dirent, filldir_t filldir) 
const struct file_operations bfs_dir_operations = {

	.read		= generic_read_dir,

	.readdir	= bfs_readdir,

	.fsync		= simple_fsync,

	.fsync		= generic_file_fsync,

	.llseek		= generic_file_llseek,

};

fs/ext2/file.c

+1 −1
Original line number Diff line number Diff line
@@ -46,7 +46,7 @@ int ext2_fsync(struct file *file, int datasync) 
	struct super_block *sb = file->f_mapping->host->i_sb;

	struct address_space *mapping = sb->s_bdev->bd_inode->i_mapping;



	ret = simple_fsync(file, datasync);

	ret = generic_file_fsync(file, datasync);

	if (ret == -EIO || test_and_clear_bit(AS_EIO, &mapping->flags)) {

		/* We don't really know where the IO error happened... */

		ext2_error(sb, __func__,

CRA Git | Maintained and supported by SUSTech CRA and CCSE