Commit 1acb8f2a authored Oct 04, 2019 by Navid Emamdoost Committed by David S. Miller Oct 04, 2019

net: qlogic: Fix memory leak in ql_alloc_large_buffers

In ql_alloc_large_buffers, a new skb is allocated via netdev_alloc_skb.
This skb should be released if pci_dma_mapping_error fails.

Fixes: 0f8ab89e ("qla3xxx: Check return code from pci_map_single() in ql_release_to_lrg_buf_free_list(), ql_populate_free_queue(), ql_alloc_large_buffers(), and ql3xxx_send()")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a0c2dc1f

drivers/net/ethernet/qlogic/qla3xxx.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2787,6 +2787,7 @@ static int ql_alloc_large_buffers(struct ql3_adapter *qdev)
		netdev_err(qdev->ndev,
		"PCI mapping failed with error: %d\n",
		err);
		dev_kfree_skb_irq(skb);
		ql_free_large_buffers(qdev);
		return -ENOMEM;
		}

Admin message