Commit 1ac7b090 authored by Antoine Tenart's avatar Antoine Tenart Committed by David S. Miller
Browse files

net: phy: mscc: add missing shift for media operation mode selection 



This patch adds a missing shift for the media operation mode selection.
This does not fix the driver as the current operation mode (copper) has
a value of 0, but this wouldn't work for other modes.

Signed-off-by: default avatarAntoine Tenart <antoine.tenart@bootlin.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 92040c6d

drivers/net/phy/mscc.c

+3 −3
Original line number Diff line number Diff line
@@ -2813,8 +2813,8 @@ static int vsc8584_config_init(struct phy_device *phydev) 


	val = phy_read(phydev, MSCC_PHY_EXT_PHY_CNTL_1);

	val &= ~(MEDIA_OP_MODE_MASK | VSC8584_MAC_IF_SELECTION_MASK);

	val |= MEDIA_OP_MODE_COPPER | (VSC8584_MAC_IF_SELECTION_SGMII <<

				       VSC8584_MAC_IF_SELECTION_POS);

	val |= (MEDIA_OP_MODE_COPPER << MEDIA_OP_MODE_POS) |

	       (VSC8584_MAC_IF_SELECTION_SGMII << VSC8584_MAC_IF_SELECTION_POS);

	ret = phy_write(phydev, MSCC_PHY_EXT_PHY_CNTL_1, val);



	ret = genphy_soft_reset(phydev);
@@ -3276,7 +3276,7 @@ static int vsc8514_config_init(struct phy_device *phydev) 
		return ret;



	ret = phy_modify(phydev, MSCC_PHY_EXT_PHY_CNTL_1, MEDIA_OP_MODE_MASK,

			 MEDIA_OP_MODE_COPPER);

			 MEDIA_OP_MODE_COPPER << MEDIA_OP_MODE_POS);



	if (ret)

		return ret;

CRA Git | Maintained and supported by SUSTech CRA and CCSE