Commit 1ac3836c authored Apr 27, 2006 by Daniel Drake Committed by Linus Torvalds Apr 28, 2006

[PATCH] tipar oops fix



If compiled into the kernel, parport_register_driver() is called before the
parport driver has been initalised.

This means that it is expected that tp_count is 0 after the
parport_register_driver() call() - tipar's attach function will not be
called until later during bootup.

Signed-off-by: Daniel Drake <dsd@gentoo.org>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 13e87ec6

drivers/char/tipar.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -515,7 +515,7 @@ tipar_init_module(void)
		err = PTR_ERR(tipar_class);
		goto out_chrdev;
		}
		if (parport_register_driver(&tipar_driver) \|\| tp_count == 0) {
		if (parport_register_driver(&tipar_driver)) {
		printk(KERN_ERR "tipar: unable to register with parport\n");
		err = -EIO;
		goto out_class;

Admin message