Commit 1abecfca authored Oct 16, 2019 by Yunfeng Ye Committed by Arnaldo Carvalho de Melo Oct 16, 2019

perf kmem: Fix memory leak in compact_gfp_flags()



The memory @orig_flags is allocated by strdup(), it is freed on the
normal path, but leak to free on the error path.

Fix this by adding free(orig_flags) on the error path.

Fixes: 0e111156 ("perf kmem: Print gfp flags in human readable string")
Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Feilong Lin <linfeilong@huawei.com>
Cc: Hu Shiyuan <hushiyuan@huawei.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/f9e9f458-96f3-4a97-a1d5-9feec2420e07@huawei.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 5eca1379

tools/perf/builtin-kmem.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -691,6 +691,7 @@ static char compact_gfp_flags(char gfp_flags)
		new = realloc(new_flags, len + strlen(cpt) + 2);
		if (new == NULL) {
		free(new_flags);
		free(orig_flags);
		return NULL;
		}

Admin message