Commit 1aae1394 authored Oct 01, 2019 by Yoshihiro Shimoda Committed by Greg Kroah-Hartman Oct 04, 2019

usb: renesas_usbhs: gadget: Do not discard queues in usb_ep_set_{halt,wedge}()



The commit 97664a20 ("usb: renesas_usbhs: shrink spin lock area")
had added a usbhsg_pipe_disable() calling into
__usbhsg_ep_set_halt_wedge() accidentally. But, this driver should
not call the usbhsg_pipe_disable() because the function discards
all queues. So, this patch removes it.

Fixes: 97664a20 ("usb: renesas_usbhs: shrink spin lock area")
Cc: <stable@vger.kernel.org> # v3.1+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Link: https://lore.kernel.org/r/1569924633-322-2-git-send-email-yoshihiro.shimoda.uh@renesas.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 792e559e

drivers/usb/renesas_usbhs/mod_gadget.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -723,8 +723,6 @@ static int __usbhsg_ep_set_halt_wedge(struct usb_ep *ep, int halt, int wedge)
		struct device *dev = usbhsg_gpriv_to_dev(gpriv);
		unsigned long flags;

		usbhsg_pipe_disable(uep);

		dev_dbg(dev, "set halt %d (pipe %d)\n",
		halt, usbhs_pipe_number(pipe));

Admin message