Commit 1aaad49e authored Jul 06, 2009 by Frans Pop Committed by Ingo Molnar Jul 10, 2009

printk: Restore previous console_loglevel when re-enabling logging

When logging to console is disabled from userspace using klogctl()
and later re-enabled, console_loglevel gets set to the default
log level instead to the previous value.

This means that if the kernel was booted with 'quiet', the boot is
suddenly no longer quiet after logging to console gets re-enabled.

Save the current console_loglevel when logging is disabled and
restore to that value. If the log level is set to a specific value
while disabled, this is interpreted as an implicit re-enabling of
the logging.

The problem that prompted this patch is described in:

    http://lkml.org/lkml/2009/6/28/234



There are two variations possible on the patch below:

 1) If klogctl(7) is called while logging is not disabled, then set level
    to default (partially preserving current functionality):
  	case 7:		/* Enable logging to console */
 -		console_loglevel = default_console_loglevel;
 +		if (saved_console_loglevel == -1)
 +			console_loglevel = default_console_loglevel;
 +		else {
 +			console_loglevel = saved_console_loglevel;
 +			saved_console_loglevel = -1;
 +		}

 2) If klogctl(8) is called while logging is disabled, then don't enable
    logging, but remember the requested value for when logging does get
    enabled again:
  	case 8:		/* Set level of messages printed to console */
 [...]
 - 		console_loglevel = len;
 +		if (saved_console_loglevel == -1)
 +			console_loglevel = len;
 +		else
 +			saved_console_loglevel = len;

Yet another option would be to ignore the request.

Signed-off-by: Frans Pop <elendil@planet.nl>
Cc: cryptsetup@packages.debian.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
LKML-Reference: <200907061331.49930.elendil@planet.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 8259cf43

kernel/printk.c

+10 −1

Original line number	Diff line number	Diff line
		@@ -67,6 +67,8 @@ int console_printk[4] = {
		DEFAULT_CONSOLE_LOGLEVEL, /* default_console_loglevel */
		};

		static int saved_console_loglevel = -1;

		/*
		* Low level drivers may need that to know if they can schedule in
		* their unblank() callback or not. So let's export it.
		@@ -378,10 +380,15 @@ int do_syslog(int type, char __user *buf, int len)
		logged_chars = 0;
		break;
		case 6: /* Disable logging to console */
		if (saved_console_loglevel == -1)
		saved_console_loglevel = console_loglevel;
		console_loglevel = minimum_console_loglevel;
		break;
		case 7: /* Enable logging to console */
		console_loglevel = default_console_loglevel;
		if (saved_console_loglevel != -1) {
		console_loglevel = saved_console_loglevel;
		saved_console_loglevel = -1;
		}
		break;
		case 8: /* Set level of messages printed to console */
		error = -EINVAL;
		@@ -390,6 +397,8 @@ int do_syslog(int type, char __user *buf, int len)
		if (len < minimum_console_loglevel)
		len = minimum_console_loglevel;
		console_loglevel = len;
		/* Implicitly re-enable logging to console */
		saved_console_loglevel = -1;
		error = 0;
		break;
		case 9: /* Number of chars in the log buffer */

Admin message