Commit 1aaac38c authored Dec 02, 2020 by Qu Wenruo Committed by David Sterba Dec 09, 2020

btrfs: don't allow tree block to cross page boundary for subpage support



As a preparation for subpage sector size support (allowing filesystem
with sector size smaller than page size to be mounted) if the sector
size is smaller than page size, we don't allow tree block to be read if
it crosses 64K(*) boundary.

The 64K is selected because:

- we are only going to support 64K page size for subpage for now
- 64K is also the maximum supported node size

This ensures that tree blocks are always contained in one page for a
system with 64K page size, which can greatly simplify the handling.

Otherwise we would have to do complex multi-page handling of tree
blocks.  Currently there is no way to create such tree blocks.

In kernel we have avoided such tree blocks allocation even on 4K page
size, as it can lead to RAID56 stripe scrubbing.

While btrfs-progs have fixed its chunk allocator since 2016 for convert,
and has extra checks to do the same behavior as the kernel.

Just add such graceful checks in case of an ancient filesystem.

Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent deb67895

fs/btrfs/extent_io.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -5273,6 +5273,14 @@ struct extent_buffer alloc_extent_buffer(struct btrfs_fs_info fs_info,
		return ERR_PTR(-EINVAL);
		}

		if (fs_info->sectorsize < PAGE_SIZE &&
		offset_in_page(start) + len > PAGE_SIZE) {
		btrfs_err(fs_info,
		"tree block crosses page boundary, start %llu nodesize %lu",
		start, len);
		return ERR_PTR(-EINVAL);
		}

		eb = find_extent_buffer(fs_info, start);
		if (eb)
		return eb;

Admin message