Commit 1aa9bc5b authored Mar 14, 2012 by Alexey Orishko Committed by David S. Miller Mar 16, 2012

usbnet: use netif_tx_wake_queue instead of netif_start_queue



If host is going to autosuspend function with two interfaces and
if IP packet has arrived in-between of two usbnet_suspend() callbacks,
i.e usbnet_resume() is called in-between, tx data flow is stopped.
When autosuspend timer expires and device is put to autosuspend
again, tx queue is waked up and data can be sent again.
This behavior might be repeated several times in a row.

Tested on Intel/ARM.

Reviewed-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
Tested-by: Dmitry Tarnyagin <dmitry.tarnyagin@stericsson.com>
Signed-off-by: Alexey Orishko <alexey.orishko@stericsson.com>
Acked-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6a228452

drivers/net/usb/usbnet.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1535,7 +1535,7 @@ int usbnet_resume (struct usb_interface *intf)

	if (test_bit(EVENT_DEV_OPEN, &dev->flags)) {		if (test_bit(EVENT_DEV_OPEN, &dev->flags)) {
	if (!(dev->txq.qlen >= TX_QLEN(dev)))		if (!(dev->txq.qlen >= TX_QLEN(dev)))
	netif_start_queue(dev->net);		netif_tx_wake_all_queues(dev->net);
	tasklet_schedule (&dev->bh);		tasklet_schedule (&dev->bh);
	}		}
	}		}

Admin message