Commit 1aa9b4b9 authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds
Browse files

[PATCH] revert "retries in ext3_prepare_write() violate ordering requirements" 



Revert e92a4d59.

Dmitry points out

"When we block_prepare_write() failed while ext3_prepare_write() we jump to
 "failure" label and call ext3_prepare_failure() witch search last mapped bh
 and invoke commit_write untill it.  This is wrong!!  because some bh from
 begining to the last mapped bh may be not uptodate.  As a result we commit to
 disk not uptodate page content witch contains garbage from previous usage."

and

"Unexpected file size increasing."

   Call trace the same as it was in first issue but result is different.
   For example we have file with i_size is zero.  we want write two blocks ,
   but fs has only one free block.

   ->ext3_prepare_write(...from == 0, to == 2048)
     retry:
     ->block_prepare_write() == -ENOSPC# we failed but allocated one block here.
     ->ext3_prepare_failure()
       ->commit_write( from == 0, to == 1024) # after this i_size becomes 1024 :)
     if (ret == -ENOSPC && ext3_should_retry_alloc(inode->i_sb, &retries))
        goto retry;

   Finally when all retries will be spended ext3_prepare_failure return
   -ENOSPC, but i_size was increased and later block trimm procedures can't
   help here.

We don't appear to have the horsepower to fix these issues, so let's put
things back the way they were for now.

Cc: Kirill Korotaev <dev@openvz.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Ken Chen <kenneth.w.chen@intel.com>
Cc: Andrey Savochkin <saw@sw.ru>
Cc: <linux-ext4@vger.kernel.org>
Cc: Dmitriy Monakhov <dmonakhov@openvz.org>
Cc: <stable@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 03221702

fs/ext3/inode.c

+10 −75
Original line number Diff line number Diff line
@@ -1148,102 +1148,37 @@ static int do_journal_get_write_access(handle_t *handle, 
	return ext3_journal_get_write_access(handle, bh);

}



/*

 * The idea of this helper function is following:

 * if prepare_write has allocated some blocks, but not all of them, the

 * transaction must include the content of the newly allocated blocks.

 * This content is expected to be set to zeroes by block_prepare_write().

 * 2006/10/14  SAW

 */

static int ext3_prepare_failure(struct file *file, struct page *page,

				unsigned from, unsigned to)

{

	struct address_space *mapping;

	struct buffer_head *bh, *head, *next;

	unsigned block_start, block_end;

	unsigned blocksize;

	int ret;

	handle_t *handle = ext3_journal_current_handle();



	mapping = page->mapping;

	if (ext3_should_writeback_data(mapping->host)) {

		/* optimization: no constraints about data */

skip:

		return ext3_journal_stop(handle);

	}



	head = page_buffers(page);

	blocksize = head->b_size;

	for (	bh = head, block_start = 0;

		bh != head || !block_start;

	    	block_start = block_end, bh = next)

	{

		next = bh->b_this_page;

		block_end = block_start + blocksize;

		if (block_end <= from)

			continue;

		if (block_start >= to) {

			block_start = to;

			break;

		}

		if (!buffer_mapped(bh))

		/* prepare_write failed on this bh */

			break;

		if (ext3_should_journal_data(mapping->host)) {

			ret = do_journal_get_write_access(handle, bh);

			if (ret) {

				ext3_journal_stop(handle);

				return ret;

			}

		}

	/*

	 * block_start here becomes the first block where the current iteration

	 * of prepare_write failed.

	 */

	}

	if (block_start <= from)

		goto skip;



	/* commit allocated and zeroed buffers */

	return mapping->a_ops->commit_write(file, page, from, block_start);

}



static int ext3_prepare_write(struct file *file, struct page *page,

			      unsigned from, unsigned to)

{

	struct inode *inode = page->mapping->host;

	int ret, ret2;

	int needed_blocks = ext3_writepage_trans_blocks(inode);

	int ret, needed_blocks = ext3_writepage_trans_blocks(inode);

	handle_t *handle;

	int retries = 0;



retry:

	handle = ext3_journal_start(inode, needed_blocks);

	if (IS_ERR(handle))

		return PTR_ERR(handle);

	if (IS_ERR(handle)) {

		ret = PTR_ERR(handle);

		goto out;

	}

	if (test_opt(inode->i_sb, NOBH) && ext3_should_writeback_data(inode))

		ret = nobh_prepare_write(page, from, to, ext3_get_block);

	else

		ret = block_prepare_write(page, from, to, ext3_get_block);

	if (ret)

		goto failure;

		goto prepare_write_failed;



	if (ext3_should_journal_data(inode)) {

		ret = walk_page_buffers(handle, page_buffers(page),

				from, to, NULL, do_journal_get_write_access);

		if (ret)

			/* fatal error, just put the handle and return */

			journal_stop(handle);

	}

	return ret;



failure:

	ret2 = ext3_prepare_failure(file, page, from, to);

	if (ret2 < 0)

		return ret2;

prepare_write_failed:

	if (ret)

		ext3_journal_stop(handle);

	if (ret == -ENOSPC && ext3_should_retry_alloc(inode->i_sb, &retries))

		goto retry;

	/* retry number exceeded, or other error like -EDQUOT */

out:

	return ret;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE