iommu/vt-d: Remove change_pte notifier (1a9eb9b9) · Commits · 戴 / test

The change_pte() interface is tailored for PFN updates, while the other notifier invalidate_range() should be enough for Intel IOMMU cache flushing. Actually we've done similar thing for AMD IOMMU already in ("iommu/amd: Remove change_pte mmu_notifier call-back", 2014-07-30) but the Intel IOMMU driver still have it. Signed-off-by:

Peter Xu <peterx@redhat.com> Signed-off-by:

Joerg Roedel <jroedel@suse.de>

drivers/iommu/intel-svm.c

+0 −9

Original line number	Diff line number	Diff line
		@@ -180,14 +180,6 @@ static void intel_flush_svm_range(struct intel_svm *svm, unsigned long address,
		rcu_read_unlock();
		}

		static void intel_change_pte(struct mmu_notifier mn, struct mm_struct mm,
		unsigned long address, pte_t pte)
		{
		struct intel_svm *svm = container_of(mn, struct intel_svm, notifier);

		intel_flush_svm_range(svm, address, 1, 1, 0);
		}

		/* Pages have been freed at this point */
		static void intel_invalidate_range(struct mmu_notifier *mn,
		struct mm_struct *mm,
		@@ -227,7 +219,6 @@ static void intel_mm_release(struct mmu_notifier mn, struct mm_struct mm)

		static const struct mmu_notifier_ops intel_mmuops = {
		.release = intel_mm_release,
		.change_pte = intel_change_pte,
		.invalidate_range = intel_invalidate_range,
		};

Admin message