Commit 1a8bf67d authored Mar 26, 2020 by Hans de Goede

drm/fb-helper: Add TODO for making drm_fb_helper_alloc_fbi fill apertures



Currently drivers using drm_fbdev_generic_setup() end up with a single
empty aperture in their fb_info struct.

Not having the proper info in the apertures list causes
register_framebuffer to not remove conflicting framebuffers,
which some drivers currently workaround by manually calling
drm_fb_helper_remove_conflicting_pci_framebuffers().

Add a TODO as a reminder that we need to fix this.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200326151009.102377-1-hdegoede@redhat.com

parent 5ea5647f

drivers/gpu/drm/drm_fb_helper.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -514,6 +514,14 @@ struct fb_info drm_fb_helper_alloc_fbi(struct drm_fb_helper fb_helper)
		if (ret)
		goto err_release;

		/*
		* TODO: We really should be smarter here and alloc an apperture
		* for each IORESOURCE_MEM resource helper->dev->dev has and also
		* init the ranges of the appertures based on the resources.
		* Note some drivers currently count on there being only 1 empty
		* aperture and fill this themselves, these will need to be dealt
		* with somehow when fixing this.
		*/
		info->apertures = alloc_apertures(1);
		if (!info->apertures) {
		ret = -ENOMEM;

Admin message