Commit 1a81542a authored Mar 14, 2019 by Peter Zijlstra Committed by Ingo Molnar Apr 03, 2019

perf/x86/intel: Simplify intel_tfa_commit_scheduling()



validate_group() calls x86_schedule_events(.assign=NULL) and therefore
will not call intel_tfa_commit_scheduling(). So there is no point in
checking cpuc->is_fake, we'll never get there.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 5e7a8ca3

arch/x86/events/intel/core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2015,7 +2015,7 @@ static void intel_tfa_commit_scheduling(struct cpu_hw_events *cpuc, int idx, int
		/*
		* We're going to use PMC3, make sure TFA is set before we touch it.
		*/
		if (cntr == 3 && !cpuc->is_fake)
		if (cntr == 3)
		intel_set_tfa(cpuc, true);
		}

Admin message