Commit 1a66c7c3 authored Apr 18, 2014 by Lukas Czerner Committed by Theodore Ts'o Apr 18, 2014

ext4: use filemap_write_and_wait_range() correctly in collapse range



Currently we're passing -1 as lend argumnet for
filemap_write_and_wait_range() which is wrong since lend is signed type
so it would cause some confusion and we might not write_and_wait for the
entire range we're expecting to write.

Fix it by using LLONG_MAX instead.

Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

parent 694c793f

fs/ext4/extents.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -5415,7 +5415,7 @@ int ext4_collapse_range(struct inode *inode, loff_t offset, loff_t len)
		}

		/* Write out all dirty pages */
		ret = filemap_write_and_wait_range(inode->i_mapping, offset, -1);
		ret = filemap_write_and_wait_range(inode->i_mapping, offset, LLONG_MAX);
		if (ret)
		return ret;

Admin message