fb: epson1355fb: kill off dead sh support (1a3f2881) · Commits · 戴 / test

The SH board that was the only user for this code was removed entirely from the kernel quite some time ago, so there's no reason to leave the stubs in place. Additionally this driver was completely broken anyways, so there's not really a lot of point in fixing it up either. I can't imagine that this driver gets any testing on ARM either, given that FB_BLANK_UNBLANKING doesn't exist, and kills the build regardless of which platform is compiling. This fixes that, too. It wouldn't be a lot of work to finish the platform device conversion and go with a generic 8-bit read/write_reg and kill off the architecture dependence completely, should someone have any use for this driver. Signed-off-by:

Paul Mundt <lethal@linux-sh.org> Acked-by:

Antonino Daplas <adaplas@gmail.com> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

Linus Torvalds <torvalds@linux-foundation.org>

drivers/video/Kconfig

+1 −1

Original line number	Diff line number	Diff line
		@@ -812,7 +812,7 @@ config FB_PVR2

		config FB_EPSON1355
		bool "Epson 1355 framebuffer support"
		depends on (FB = y) && (SUPERH \|\| ARCH_CEIVA)
		depends on (FB = y) && ARCH_CEIVA
		select FB_CFB_FILLRECT
		select FB_CFB_COPYAREA
		select FB_CFB_IMAGEBLIT

drivers/video/epson1355fb.c

+2 −14

Original line number	Diff line number	Diff line
		@@ -68,19 +68,7 @@ struct epson1355_par {

		/* ------------------------------------------------------------------------- */

		#ifdef CONFIG_SUPERH

		static inline u8 epson1355_read_reg(int index)
		{
		return ctrl_inb(par.reg_addr + index);
		}

		static inline void epson1355_write_reg(u8 data, int index)
		{
		ctrl_outb(data, par.reg_addr + index);
		}

		#elif defined(CONFIG_ARM)
		#if defined(CONFIG_ARM)

		# ifdef CONFIG_ARCH_CEIVA
		# include <asm/arch/hardware.h>
		@@ -290,7 +278,7 @@ static int epson1355fb_blank(int blank_mode, struct fb_info *info)
		struct epson1355_par *par = info->par;

		switch (blank_mode) {
		case FB_BLANK_UNBLANKING:
		case FB_BLANK_UNBLANK:
		case FB_BLANK_NORMAL:
		lcd_enable(par, 1);
		backlight_enable(1);

Admin message