Commit 1a392b3d authored Jan 23, 2019 by Liu Jian Committed by Greg Kroah-Hartman Jan 31, 2019

driver: uio: fix possible memory leak in __uio_register_device



'idev' is malloced in __uio_register_device() and leak free it before
leaving from the uio_get_minor() error handing case, it will cause
memory leak.

Fixes: a93e7b33 ("uio: Prevent device destruction while fds are open")
Signed-off-by: Liu Jian <liujian56@huawei.com>
Reviewed-by: Hamish Martin <hamish.martin@alliedtelesis.co.nz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9bfd8198

drivers/uio/uio.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -940,8 +940,10 @@ int __uio_register_device(struct module *owner,
		atomic_set(&idev->event, 0);

		ret = uio_get_minor(idev);
		if (ret)
		if (ret) {
		kfree(idev);
		return ret;
		}

		idev->dev.devt = MKDEV(uio_major, idev->minor);
		idev->dev.class = &uio_class;

Admin message