Commit 1a37a039 authored May 25, 2020 by Dinghao Liu Committed by Sebastian Reichel Jun 19, 2020

power: supply: bq24190_charger: Fix runtime PM imbalance on error



pm_runtime_get_sync() increments the runtime PM usage counter even
it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

parent 7222bd60

drivers/power/supply/bq24190_charger.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -481,8 +481,10 @@ static ssize_t bq24190_sysfs_store(struct device *dev,
		return ret;

		ret = pm_runtime_get_sync(bdi->dev);
		if (ret < 0)
		if (ret < 0) {
		pm_runtime_put_noidle(bdi->dev);
		return ret;
		}

		ret = bq24190_write_mask(bdi, info->reg, info->mask, info->shift, v);
		if (ret)

Admin message