Commit 1a3466ae authored by Anna Schumaker's avatar Anna Schumaker Committed by Trond Myklebust
Browse files

NFS: Add missing encode / decode sequence_maxsz to v4.2 operations 



These really should have been there from the beginning, but we never
noticed because there was enough slack in the RPC request for the extra
bytes. Chuck's recent patch to use au_cslack and au_rslack to compute
buffer size shrunk the buffer enough that this was now a problem for
SEEK operations on my test client.

Fixes: f4ac1674 ("nfs: Add ALLOCATE support")
Fixes: 2e72448b ("NFS: Add COPY nfs operation")
Fixes: cb95deea ("NFS OFFLOAD_CANCEL xdr")
Fixes: 624bd5b7 ("nfs: Add DEALLOCATE support")
Fixes: 1c6dcbe5 ("NFS: Implement SEEK")
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent c71c46f0

fs/nfs/nfs42xdr.c

+10 −0
Original line number Diff line number Diff line
@@ -59,43 +59,53 @@ 
#define decode_clone_maxsz		(op_decode_hdr_maxsz)



#define NFS4_enc_allocate_sz		(compound_encode_hdr_maxsz + \

					 encode_sequence_maxsz + \

					 encode_putfh_maxsz + \

					 encode_allocate_maxsz + \

					 encode_getattr_maxsz)

#define NFS4_dec_allocate_sz		(compound_decode_hdr_maxsz + \

					 decode_sequence_maxsz + \

					 decode_putfh_maxsz + \

					 decode_allocate_maxsz + \

					 decode_getattr_maxsz)

#define NFS4_enc_copy_sz		(compound_encode_hdr_maxsz + \

					 encode_sequence_maxsz + \

					 encode_putfh_maxsz + \

					 encode_savefh_maxsz + \

					 encode_putfh_maxsz + \

					 encode_copy_maxsz + \

					 encode_commit_maxsz)

#define NFS4_dec_copy_sz		(compound_decode_hdr_maxsz + \

					 decode_sequence_maxsz + \

					 decode_putfh_maxsz + \

					 decode_savefh_maxsz + \

					 decode_putfh_maxsz + \

					 decode_copy_maxsz + \

					 decode_commit_maxsz)

#define NFS4_enc_offload_cancel_sz	(compound_encode_hdr_maxsz + \

					 encode_sequence_maxsz + \

					 encode_putfh_maxsz + \

					 encode_offload_cancel_maxsz)

#define NFS4_dec_offload_cancel_sz	(compound_decode_hdr_maxsz + \

					 decode_sequence_maxsz + \

					 decode_putfh_maxsz + \

					 decode_offload_cancel_maxsz)

#define NFS4_enc_deallocate_sz		(compound_encode_hdr_maxsz + \

					 encode_sequence_maxsz + \

					 encode_putfh_maxsz + \

					 encode_deallocate_maxsz + \

					 encode_getattr_maxsz)

#define NFS4_dec_deallocate_sz		(compound_decode_hdr_maxsz + \

					 decode_sequence_maxsz + \

					 decode_putfh_maxsz + \

					 decode_deallocate_maxsz + \

					 decode_getattr_maxsz)

#define NFS4_enc_seek_sz		(compound_encode_hdr_maxsz + \

					 encode_sequence_maxsz + \

					 encode_putfh_maxsz + \

					 encode_seek_maxsz)

#define NFS4_dec_seek_sz		(compound_decode_hdr_maxsz + \

					 decode_sequence_maxsz + \

					 decode_putfh_maxsz + \

					 decode_seek_maxsz)

#define NFS4_enc_layoutstats_sz		(compound_encode_hdr_maxsz + \

CRA Git | Maintained and supported by SUSTech CRA and CCSE