kernel/padata.c: hide unused functions (19d795b6) · Commits · 戴 / test

A recent cleanup removed some exported functions that were not used anywhere, which in turn exposed the fact that some other functions in the same file are only used in some configurations. We now get a warning about them when CONFIG_HOTPLUG_CPU is disabled: kernel/padata.c:670:12: error: '__padata_remove_cpu' defined but not used [-Werror=unused-function] static int __padata_remove_cpu(struct padata_instance *pinst, int cpu) ^~~~~~~~~~~~~~~~~~~ kernel/padata.c:650:12: error: '__padata_add_cpu' defined but not used [-Werror=unused-function] static int __padata_add_cpu(struct padata_instance *pinst, int cpu) This rearranges the code so the __padata_remove_cpu/__padata_add_cpu functions are within the #ifdef that protects the code that calls them. [akpm@linux-foundation.org: coding-style fixes] Fixes: 4ba6d78c671e ("kernel/padata.c: removed unused code") Signed-off-by:

Arnd Bergmann <arnd@arndb.de> Cc: Richard Cochran <rcochran@linutronix.de> Cc: Steffen Klassert <steffen.klassert@secunet.com> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

Linus Torvalds <torvalds@linux-foundation.org>

kernel/padata.c

+37 −37

Original line number	Diff line number	Diff line
		@@ -647,6 +647,43 @@ out:
		}
		EXPORT_SYMBOL(padata_set_cpumask);

		/**
		* padata_start - start the parallel processing
		*
		* @pinst: padata instance to start
		*/
		int padata_start(struct padata_instance *pinst)
		{
		int err = 0;

		mutex_lock(&pinst->lock);

		if (pinst->flags & PADATA_INVALID)
		err = -EINVAL;

		__padata_start(pinst);

		mutex_unlock(&pinst->lock);

		return err;
		}
		EXPORT_SYMBOL(padata_start);

		/**
		* padata_stop - stop the parallel processing
		*
		* @pinst: padata instance to stop
		*/
		void padata_stop(struct padata_instance *pinst)
		{
		mutex_lock(&pinst->lock);
		__padata_stop(pinst);
		mutex_unlock(&pinst->lock);
		}
		EXPORT_SYMBOL(padata_stop);

		#ifdef CONFIG_HOTPLUG_CPU

		static int __padata_add_cpu(struct padata_instance *pinst, int cpu)
		{
		struct parallel_data *pd;
		@@ -726,43 +763,6 @@ int padata_remove_cpu(struct padata_instance *pinst, int cpu, int mask)
		}
		EXPORT_SYMBOL(padata_remove_cpu);

		/**
		* padata_start - start the parallel processing
		*
		* @pinst: padata instance to start
		*/
		int padata_start(struct padata_instance *pinst)
		{
		int err = 0;

		mutex_lock(&pinst->lock);

		if (pinst->flags & PADATA_INVALID)
		err =-EINVAL;

		__padata_start(pinst);

		mutex_unlock(&pinst->lock);

		return err;
		}
		EXPORT_SYMBOL(padata_start);

		/**
		* padata_stop - stop the parallel processing
		*
		* @pinst: padata instance to stop
		*/
		void padata_stop(struct padata_instance *pinst)
		{
		mutex_lock(&pinst->lock);
		__padata_stop(pinst);
		mutex_unlock(&pinst->lock);
		}
		EXPORT_SYMBOL(padata_stop);

		#ifdef CONFIG_HOTPLUG_CPU

		static inline int pinst_has_cpu(struct padata_instance *pinst, int cpu)
		{
		return cpumask_test_cpu(cpu, pinst->cpumask.pcpu) \|\|

Admin message