Commit 19d4c761 authored Apr 21, 2020 by Julian Wiedmann Committed by Vasily Gorbik Apr 28, 2020

s390/qdio: remove always-true condition



buf_in_between() gets passed q->u.in.ack_start as 'bufnr' parameter.

The ack_start always ranges between 0 and QDIO_MAX_BUFFERS_PER_Q - 1,
so the subsequent check will always return true. Remove it.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>

parent 9b7012df

drivers/s390/cio/qdio_main.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1450,8 +1450,7 @@ static inline int buf_in_between(int bufnr, int start, int count)
		}

		/* wrap-around case */
		if ((bufnr >= start && bufnr <= QDIO_MAX_BUFFERS_PER_Q) \|\|
		(bufnr < end))
		if (bufnr >= start \|\| bufnr < end)
		return 1;
		else
		return 0;

Admin message