Commit 19d0070a authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

timekeeping/vsyscall: Provide vdso_update_begin/end() 



Architectures can have the requirement to add additional architecture
specific data to the VDSO data page which needs to be updated independent
of the timekeeper updates.

To protect these updates vs. concurrent readers and a conflicting update
through timekeeping, provide helper functions to make such updates safe.

vdso_update_begin() takes the timekeeper_lock to protect against a
potential update from timekeeper code and increments the VDSO sequence
count to signal data inconsistency to concurrent readers. vdso_update_end()
makes the sequence count even again to signal data consistency and drops
the timekeeper lock.

[ Sven: Add interrupt disable handling to the functions ]

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarSven Schnelle <svens@linux.ibm.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20200804150124.41692-3-svens@linux.ibm.com
parent 4c5a116a

include/vdso/vsyscall.h

+3 −0
Original line number Diff line number Diff line
@@ -6,6 +6,9 @@ 


#include <asm/vdso/vsyscall.h>



unsigned long vdso_update_begin(void);

void vdso_update_end(unsigned long flags);



#endif /* !__ASSEMBLY__ */



#endif /* __VDSO_VSYSCALL_H */

kernel/time/timekeeping.c

+1 −1
Original line number Diff line number Diff line
@@ -50,7 +50,7 @@ static struct { 
	.seq = SEQCNT_ZERO(tk_core.seq),

};



static DEFINE_RAW_SPINLOCK(timekeeper_lock);

DEFINE_RAW_SPINLOCK(timekeeper_lock);

static struct timekeeper shadow_timekeeper;



/**

kernel/time/timekeeping_internal.h

+8 −3
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0 */

#ifndef _TIMEKEEPING_INTERNAL_H

#define _TIMEKEEPING_INTERNAL_H

/*

 * timekeeping debug functions

 */



#include <linux/clocksource.h>

#include <linux/spinlock.h>

#include <linux/time.h>



/*

 * timekeeping debug functions

 */

#ifdef CONFIG_DEBUG_FS

extern void tk_debug_account_sleep_time(const struct timespec64 *t);

#else
@@ -31,4 +33,7 @@ static inline u64 clocksource_delta(u64 now, u64 last, u64 mask) 
}

#endif



/* Semi public for serialization of non timekeeper VDSO updates. */

extern raw_spinlock_t timekeeper_lock;



#endif /* _TIMEKEEPING_INTERNAL_H */

kernel/time/vsyscall.c

+41 −0
Original line number Diff line number Diff line
@@ -13,6 +13,8 @@ 
#include <vdso/helpers.h>

#include <vdso/vsyscall.h>



#include "timekeeping_internal.h"



static inline void update_vdso_data(struct vdso_data *vdata,

				    struct timekeeper *tk)

{
@@ -127,3 +129,42 @@ void update_vsyscall_tz(void) 


	__arch_sync_vdso_data(vdata);

}



/**

 * vdso_update_begin - Start of a VDSO update section

 *

 * Allows architecture code to safely update the architecture specific VDSO

 * data. Disables interrupts, acquires timekeeper lock to serialize against

 * concurrent updates from timekeeping and invalidates the VDSO data

 * sequence counter to prevent concurrent readers from accessing

 * inconsistent data.

 *

 * Returns: Saved interrupt flags which need to be handed in to

 * vdso_update_end().

 */

unsigned long vdso_update_begin(void)

{

	struct vdso_data *vdata = __arch_get_k_vdso_data();

	unsigned long flags;



	raw_spin_lock_irqsave(&timekeeper_lock, flags);

	vdso_write_begin(vdata);

	return flags;

}



/**

 * vdso_update_end - End of a VDSO update section

 * @flags:	Interrupt flags as returned from vdso_update_begin()

 *

 * Pairs with vdso_update_begin(). Marks vdso data consistent, invokes data

 * synchronization if the architecture requires it, drops timekeeper lock

 * and restores interrupt flags.

 */

void vdso_update_end(unsigned long flags)

{

	struct vdso_data *vdata = __arch_get_k_vdso_data();



	vdso_write_end(vdata);

	__arch_sync_vdso_data(vdata);

	raw_spin_unlock_irqrestore(&timekeeper_lock, flags);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE