Commit 19c624c6 authored Jan 09, 2019 by Pawe? Chmiel Committed by Mauro Carvalho Chehab Jan 16, 2019

media: s5p-jpeg: Correct step and max values for V4L2_CID_JPEG_RESTART_INTERVAL



This commit corrects max and step values for v4l2 control for
V4L2_CID_JPEG_RESTART_INTERVAL. Max should be 0xffff and step should be 1.
It was found by using v4l2-compliance tool and checking result of
VIDIOC_QUERY_EXT_CTRL/QUERYMENU test.
Previously it was complaining that step was bigger than difference
between max and min.

Fixes: 15f4bc3b ("[media] s5p-jpeg: Add JPEG controls support")

Signed-off-by: Pawe? Chmiel <pawel.mikolaj.chmiel@gmail.com>
Reviewed-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent 8db63f3d

drivers/media/platform/s5p-jpeg/jpeg-core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2005,7 +2005,7 @@ static int s5p_jpeg_controls_create(struct s5p_jpeg_ctx *ctx)

		v4l2_ctrl_new_std(&ctx->ctrl_handler, &s5p_jpeg_ctrl_ops,
		V4L2_CID_JPEG_RESTART_INTERVAL,
		0, 3, 0xffff, 0);
		0, 0xffff, 1, 0);
		if (ctx->jpeg->variant->version == SJPEG_S5P)
		mask = ~0x06; /* 422, 420 */
		}

Admin message