Commit 19c38b63 authored Feb 12, 2010 by Eric W. Biederman Committed by Greg Kroah-Hartman Mar 07, 2010

sysfs: Pack sysfs_dirent more tightly.



Placing the 16bit s_mode between a pointer and a long doesn't pack well
especailly on 64bit where we wast 48 bits.  So move s_mode and
declare it as a unsigned short.  This is the sysfs backing store
after all we don't need fields extra large just in case someday
we want userspace to be able to use a larger value.

Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent f8d4f618

fs/sysfs/sysfs.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -66,8 +66,8 @@ struct sysfs_dirent {
		};

		unsigned int s_flags;
		unsigned short s_mode;
		ino_t s_ino;
		umode_t s_mode;
		struct sysfs_inode_attrs *s_iattr;
		};

Admin message