Commit 19a5b935 authored Feb 28, 2014 by Niu Yawei Committed by Greg Kroah-Hartman Feb 28, 2014

lustre/quota: improper assert in osc_quota_chkdq()



In osc_quota_chkdq(), we should never try to access oqi found
from hash, since it could have been freed by osc_quota_setdq().

Signed-off-by: Niu Yawei <yawei.niu@intel.com>
Reviewed-on: http://review.whamcloud.com/8460
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4336


Reviewed-by: Johann Lombardi <johann.lombardi@intel.com>
Reviewed-by: Fan Yong <fan.yong@intel.com>
Signed-off-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 15f13cde

drivers/staging/lustre/lustre/osc/osc_quota.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -51,11 +51,8 @@ int osc_quota_chkdq(struct client_obd *cli, const unsigned int qid[])

		oqi = cfs_hash_lookup(cli->cl_quota_hash[type], &qid[type]);
		if (oqi) {
		obd_uid id = oqi->oqi_id;

		LASSERTF(id == qid[type],
		"The ids don't match %u != %u\n",
		id, qid[type]);
		/* do not try to access oqi here, it could have been
		* freed by osc_quota_setdq() */

		/* the slot is busy, the user is about to run out of
		* quota space on this OST */

Admin message