Commit 1987fd74 authored Oct 10, 2016 by Darrick J. Wong Committed by Dave Chinner Oct 10, 2016

xfs: clear reflink flag if setting realtime flag



Since we can only turn on the rt flag if there are no data extents,
we can safely turn off the reflink flag if the rt flag is being
turned on.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reported-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>

parent 9780643c

fs/xfs/xfs_ioctl.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1034,9 +1034,9 @@ xfs_ioctl_setattr_xflags(
		return -EINVAL;
		}

		/* Don't allow us to set realtime mode for a reflinked file. */
		/* Clear reflink if we are actually able to set the rt flag. */
		if ((fa->fsx_xflags & FS_XFLAG_REALTIME) && xfs_is_reflink_inode(ip))
		return -EINVAL;
		ip->i_d.di_flags2 &= ~XFS_DIFLAG2_REFLINK;

		/* Don't allow us to set DAX mode for a reflinked file for now. */
		if ((fa->fsx_xflags & FS_XFLAG_DAX) && xfs_is_reflink_inode(ip))

Admin message