Commit 1987b1b8 authored Apr 11, 2019 by Bartosz Golaszewski Committed by Richard Weinberger May 07, 2019

um: irq: don't set the chip for all irqs



Setting a chip for an interrupt marks it as allocated. Since UM doesn't
support dynamic interrupt numbers (yet), it means we cannot simply
increase NR_IRQS and then use the free irqs between LAST_IRQ and NR_IRQS
with gpio-mockup or iio testing drivers as irq_alloc_descs() will fail
after not being able to neither find an unallocated range of interrupts
nor expand the range.

Only call irq_set_chip_and_handler() for irqs until LAST_IRQ.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Acked-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Signed-off-by: Richard Weinberger <richard@nod.at>

parent ea70d791

arch/um/kernel/irq.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -479,7 +479,7 @@ void __init init_IRQ(void)
		irq_set_chip_and_handler(TIMER_IRQ, &SIGVTALRM_irq_type, handle_edge_irq);


		for (i = 1; i < NR_IRQS; i++)
		for (i = 1; i < LAST_IRQ; i++)
		irq_set_chip_and_handler(i, &normal_irq_type, handle_edge_irq);
		/* Initialize EPOLL Loop */
		os_setup_epoll();

Admin message