Commit 19870def authored by Alexander van Heukelum's avatar Alexander van Heukelum Committed by Ingo Molnar
Browse files

x86, bitops: select the generic bitmap search functions 



Introduce GENERIC_FIND_FIRST_BIT and GENERIC_FIND_NEXT_BIT in
lib/Kconfig, defaulting to off. An arch that wants to use the
generic implementation now only has to use a select statement
to include them.

I added an always-y option (X86_CPU) to arch/x86/Kconfig.cpu
and used that to select the generic search functions. This
way ARCH=um SUBARCH=i386 automatically picks up the change
too, and arch/um/Kconfig.i386 can therefore be simplified a
bit. ARCH=um SUBARCH=x86_64 does things differently, but
still compiles fine. It seems that a "def_bool y" always
wins over a "def_bool n"?

Signed-off-by: default avatarAlexander van Heukelum <heukelum@fastmail.fm>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent f19dcf4a

arch/um/Kconfig.i386

+0 −8
Original line number Diff line number Diff line
@@ -39,14 +39,6 @@ config ARCH_REUSE_HOST_VSYSCALL_AREA 
	bool

	default y



config GENERIC_FIND_FIRST_BIT

	bool

	default y



config GENERIC_FIND_NEXT_BIT

	bool

	default y



config GENERIC_HWEIGHT

	bool

	default y

arch/um/Kconfig.x86_64

+0 −8
Original line number Diff line number Diff line
@@ -34,14 +34,6 @@ config SMP_BROKEN 
	bool

	default y



config GENERIC_FIND_FIRST_BIT

	bool

	default y



config GENERIC_FIND_NEXT_BIT

	bool

	default y



config GENERIC_HWEIGHT

	bool

	default y

arch/x86/Kconfig

+0 −6
Original line number Diff line number Diff line
@@ -77,12 +77,6 @@ config GENERIC_BUG 
	def_bool y

	depends on BUG



config GENERIC_FIND_FIRST_BIT

	def_bool y



config GENERIC_FIND_NEXT_BIT

	def_bool y



config GENERIC_HWEIGHT

	def_bool y

arch/x86/Kconfig.cpu

+5 −0
Original line number Diff line number Diff line
@@ -278,6 +278,11 @@ config GENERIC_CPU 


endchoice



config X86_CPU

	def_bool y

	select GENERIC_FIND_FIRST_BIT

	select GENERIC_FIND_NEXT_BIT



config X86_GENERIC

	bool "Generic x86 support"

	depends on X86_32

lib/Kconfig

+6 −0
Original line number Diff line number Diff line
@@ -7,6 +7,12 @@ menu "Library routines" 
config BITREVERSE

	tristate



config GENERIC_FIND_FIRST_BIT

	def_bool n



config GENERIC_FIND_NEXT_BIT

	def_bool n



config CRC_CCITT

	tristate "CRC-CCITT functions"

	help

CRA Git | Maintained and supported by SUSTech CRA and CCSE