net/rds: Remove two WARN_ON() statements (197c782e) · Commits · 戴 / test

Remove two WARN_ON() statements that verify something that is guaranteed by the RDMA API, namely that the failed_wr pointer is not touched if an ib_post_send() call succeeds and that it points at the failed wr if an ib_post_send() call fails. Signed-off-by:

Bart Van Assche <bart.vanassche@wdc.com> Acked-by:

Santosh Shilimkar <santosh.shilimkar@oracle.com> Signed-off-by:

Jason Gunthorpe <jgg@mellanox.com>

net/rds/ib_frmr.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -137,7 +137,6 @@ static int rds_ib_post_reg_frmr(struct rds_ib_mr *ibmr)

		failed_wr = &reg_wr.wr;
		ret = ib_post_send(ibmr->ic->i_cm_id->qp, &reg_wr.wr, &failed_wr);
		WARN_ON(failed_wr != &reg_wr.wr);
		if (unlikely(ret)) {
		/* Failure here can be because of -ENOMEM as well */
		frmr->fr_state = FRMR_IS_STALE;
		@@ -257,7 +256,6 @@ static int rds_ib_post_inv(struct rds_ib_mr *ibmr)

		failed_wr = s_wr;
		ret = ib_post_send(i_cm_id->qp, s_wr, &failed_wr);
		WARN_ON(failed_wr != s_wr);
		if (unlikely(ret)) {
		frmr->fr_state = FRMR_IS_STALE;
		frmr->fr_inv = false;

Admin message