Commit 1963507e authored Mar 16, 2020 by Madhuparna Bhowmik Committed by David S. Miller Mar 16, 2020

net: kcm: kcmproc.c: Fix RCU list suspicious usage warning



This path fixes the suspicious RCU usage warning reported by
kernel test robot.

net/kcm/kcmproc.c:#RCU-list_traversed_in_non-reader_section

There is no need to use list_for_each_entry_rcu() in
kcm_stats_seq_show() as the list is always traversed under
knet->mutex held.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 10ee4b87

net/kcm/kcmproc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -261,7 +261,7 @@ static int kcm_stats_seq_show(struct seq_file seq, void v)
		aggregate_strp_stats(&knet->aggregate_strp_stats,
		&strp_stats);

		list_for_each_entry_rcu(mux, &knet->mux_list, kcm_mux_list) {
		list_for_each_entry(mux, &knet->mux_list, kcm_mux_list) {
		spin_lock_bh(&mux->lock);
		aggregate_mux_stats(&mux->stats, &mux_stats);
		aggregate_psock_stats(&mux->aggregate_psock_stats,

Admin message