Commit 1954e9a9 authored Jun 27, 2018 by Bart Van Assche Committed by Jens Axboe Jul 09, 2018

block: Document how blk_update_request() handles RQF_SPECIAL_PAYLOAD requests



The payload of struct request is stored in the request.bio chain if
the RQF_SPECIAL_PAYLOAD flag is not set and in request.special_vec if
RQF_SPECIAL_PAYLOAD has been set. However, blk_update_request()
iterates over req->bio whether or not RQF_SPECIAL_PAYLOAD has been
set. Additionally, the RQF_SPECIAL_PAYLOAD flag is ignored by
blk_rq_bytes() which means that the value returned by that function
is incorrect if the RQF_SPECIAL_PAYLOAD flag has been set. It is not
clear to me whether this is an oversight or whether this happened on
purpose. Anyway, document that it is known that both functions ignore
RQF_SPECIAL_PAYLOAD. See also commit f9d03f96 ("block: improve
handling of the magic discard payload").

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent d05d1998

block/blk-core.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -3056,6 +3056,10 @@ EXPORT_SYMBOL_GPL(blk_steal_bios);
		* Passing the result of blk_rq_bytes() as @nr_bytes guarantees
		* %false return from this function.
		*
		* Note:
		* The RQF_SPECIAL_PAYLOAD flag is ignored on purpose in both
		* blk_rq_bytes() and in blk_update_request().
		*
		* Return:
		* %false - this request doesn't have any more data
		* %true - this request has more data

Admin message