mtd: rawnand: gpmi: Stop using nand_release() (194f6c48) · Commits · 戴 / test

This helper is not very useful and very often people get confused: they use nand_release() instead of nand_cleanup(). Let's stop using nand_release() by calling mtd_device_unregister() and nand_cleanup() directly. Signed-off-by:

Miquel Raynal <miquel.raynal@bootlin.com> Cc: Han Xu <han.xu@nxp.com> Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-20-miquel.raynal@bootlin.com

drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -2696,11 +2696,15 @@ exit_acquire_resources:
		static int gpmi_nand_remove(struct platform_device *pdev)
		{
		struct gpmi_nand_data *this = platform_get_drvdata(pdev);
		struct nand_chip *chip = &this->nand;
		int ret;

		pm_runtime_put_sync(&pdev->dev);
		pm_runtime_disable(&pdev->dev);

		nand_release(&this->nand);
		ret = mtd_device_unregister(nand_to_mtd(chip));
		WARN_ON(ret);
		nand_cleanup(chip);
		gpmi_free_dma_buffer(this);
		release_resources(this);
		return 0;

Admin message