bitops: Revert cbe96375025e ("bitops: Add clear/set_bit32() to linux/bitops.h") (1943dc07) · Commits · 戴 / test

These ops are not endian safe and may break on architectures which have aligment requirements. Reverts: ("bitops: Add clear/set_bit32() to linux/bitops.h") Reported-by:

Peter Zijlstra <peterz@infradead.org> Signed-off-by:

Thomas Gleixner <tglx@linutronix.de> Cc: Andi Kleen <ak@linux.intel.com>

include/linux/bitops.h

+0 −26

Original line number	Diff line number	Diff line
		@@ -227,32 +227,6 @@ static inline unsigned long __ffs64(u64 word)
		return __ffs((unsigned long)word);
		}

		/*
		* clear_bit32 - Clear a bit in memory for u32 array
		* @nr: Bit to clear
		* @addr: u32 * address of bitmap
		*
		* Same as clear_bit, but avoids needing casts for u32 arrays.
		*/

		static __always_inline void clear_bit32(long nr, volatile u32 *addr)
		{
		clear_bit(nr, (volatile unsigned long *)addr);
		}

		/*
		* set_bit32 - Set a bit in memory for u32 array
		* @nr: Bit to clear
		* @addr: u32 * address of bitmap
		*
		* Same as set_bit, but avoids needing casts for u32 arrays.
		*/

		static __always_inline void set_bit32(long nr, volatile u32 *addr)
		{
		set_bit(nr, (volatile unsigned long *)addr);
		}

		#ifdef __KERNEL__

		#ifndef set_mask_bits

Admin message