Commit 19429363 authored by Dave Chinner's avatar Dave Chinner Committed by Dave Chinner
Browse files

xfs: rename variables in xfs_iflush_cluster for clarity 



The cluster inode variable uses unconventional naming - iq - which
makes it hard to distinguish it between the inode passed into the
function - ip - and that is a vector for mistakes to be made.
Rename all the cluster inode variables to use a more conventional
prefixes to reduce potential future confusion (cilist, cilist_size,
cip).

Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
parent 5a90e53e

fs/xfs/xfs_inode.c

+37 −37
Original line number Diff line number Diff line
@@ -3162,16 +3162,16 @@ out_trans_cancel: 


STATIC int

xfs_iflush_cluster(

	xfs_inode_t	*ip,

	xfs_buf_t	*bp)

	struct xfs_inode	*ip,

	struct xfs_buf		*bp)

{

	xfs_mount_t		*mp = ip->i_mount;

	struct xfs_mount	*mp = ip->i_mount;

	struct xfs_perag	*pag;

	unsigned long		first_index, mask;

	unsigned long		inodes_per_cluster;

	int			ilist_size;

	xfs_inode_t		**ilist;

	xfs_inode_t		*iq;

	int			cilist_size;

	struct xfs_inode	**cilist;

	struct xfs_inode	*cip;

	int			nr_found;

	int			clcount = 0;

	int			bufwasdelwri;
@@ -3180,23 +3180,23 @@ xfs_iflush_cluster( 
	pag = xfs_perag_get(mp, XFS_INO_TO_AGNO(mp, ip->i_ino));



	inodes_per_cluster = mp->m_inode_cluster_size >> mp->m_sb.sb_inodelog;

	ilist_size = inodes_per_cluster * sizeof(xfs_inode_t *);

	ilist = kmem_alloc(ilist_size, KM_MAYFAIL|KM_NOFS);

	if (!ilist)

	cilist_size = inodes_per_cluster * sizeof(xfs_inode_t *);

	cilist = kmem_alloc(cilist_size, KM_MAYFAIL|KM_NOFS);

	if (!cilist)

		goto out_put;



	mask = ~(((mp->m_inode_cluster_size >> mp->m_sb.sb_inodelog)) - 1);

	first_index = XFS_INO_TO_AGINO(mp, ip->i_ino) & mask;

	rcu_read_lock();

	/* really need a gang lookup range call here */

	nr_found = radix_tree_gang_lookup(&pag->pag_ici_root, (void**)ilist,

	nr_found = radix_tree_gang_lookup(&pag->pag_ici_root, (void**)cilist,

					first_index, inodes_per_cluster);

	if (nr_found == 0)

		goto out_free;



	for (i = 0; i < nr_found; i++) {

		iq = ilist[i];

		if (iq == ip)

		cip = cilist[i];

		if (cip == ip)

			continue;



		/*
@@ -3205,10 +3205,10 @@ xfs_iflush_cluster( 
		 * We need to check under the i_flags_lock for a valid inode

		 * here. Skip it if it is not valid or the wrong inode.

		 */

		spin_lock(&iq->i_flags_lock);

		if (!iq->i_ino ||

		    __xfs_iflags_test(iq, XFS_ISTALE)) {

			spin_unlock(&iq->i_flags_lock);

		spin_lock(&cip->i_flags_lock);

		if (!cip->i_ino ||

		    __xfs_iflags_test(cip, XFS_ISTALE)) {

			spin_unlock(&cip->i_flags_lock);

			continue;

		}
@@ -3217,18 +3217,18 @@ xfs_iflush_cluster( 
		 * any more inodes in the list because they will also all be

		 * outside the cluster.

		 */

		if ((XFS_INO_TO_AGINO(mp, iq->i_ino) & mask) != first_index) {

			spin_unlock(&iq->i_flags_lock);

		if ((XFS_INO_TO_AGINO(mp, cip->i_ino) & mask) != first_index) {

			spin_unlock(&cip->i_flags_lock);

			break;

		}

		spin_unlock(&iq->i_flags_lock);

		spin_unlock(&cip->i_flags_lock);



		/*

		 * Do an un-protected check to see if the inode is dirty and

		 * is a candidate for flushing.  These checks will be repeated

		 * later after the appropriate locks are acquired.

		 */

		if (xfs_inode_clean(iq) && xfs_ipincount(iq) == 0)

		if (xfs_inode_clean(cip) && xfs_ipincount(cip) == 0)

			continue;



		/*
@@ -3236,15 +3236,15 @@ xfs_iflush_cluster( 
		 * then this inode cannot be flushed and is skipped.

		 */



		if (!xfs_ilock_nowait(iq, XFS_ILOCK_SHARED))

		if (!xfs_ilock_nowait(cip, XFS_ILOCK_SHARED))

			continue;

		if (!xfs_iflock_nowait(iq)) {

			xfs_iunlock(iq, XFS_ILOCK_SHARED);

		if (!xfs_iflock_nowait(cip)) {

			xfs_iunlock(cip, XFS_ILOCK_SHARED);

			continue;

		}

		if (xfs_ipincount(iq)) {

			xfs_ifunlock(iq);

			xfs_iunlock(iq, XFS_ILOCK_SHARED);

		if (xfs_ipincount(cip)) {

			xfs_ifunlock(cip);

			xfs_iunlock(cip, XFS_ILOCK_SHARED);

			continue;

		}
@@ -3255,9 +3255,9 @@ xfs_iflush_cluster( 
		 * in that function for more information as to why the initial

		 * check is not sufficient.

		 */

		if (!iq->i_ino) {

			xfs_ifunlock(iq);

			xfs_iunlock(iq, XFS_ILOCK_SHARED);

		if (!cip->i_ino) {

			xfs_ifunlock(cip);

			xfs_iunlock(cip, XFS_ILOCK_SHARED);

			continue;

		}
@@ -3265,18 +3265,18 @@ xfs_iflush_cluster( 
		 * arriving here means that this inode can be flushed.  First

		 * re-check that it's dirty before flushing.

		 */

		if (!xfs_inode_clean(iq)) {

		if (!xfs_inode_clean(cip)) {

			int	error;

			error = xfs_iflush_int(iq, bp);

			error = xfs_iflush_int(cip, bp);

			if (error) {

				xfs_iunlock(iq, XFS_ILOCK_SHARED);

				xfs_iunlock(cip, XFS_ILOCK_SHARED);

				goto cluster_corrupt_out;

			}

			clcount++;

		} else {

			xfs_ifunlock(iq);

			xfs_ifunlock(cip);

		}

		xfs_iunlock(iq, XFS_ILOCK_SHARED);

		xfs_iunlock(cip, XFS_ILOCK_SHARED);

	}



	if (clcount) {
@@ -3286,7 +3286,7 @@ xfs_iflush_cluster( 


out_free:

	rcu_read_unlock();

	kmem_free(ilist);

	kmem_free(cilist);

out_put:

	xfs_perag_put(pag);

	return 0;
@@ -3329,8 +3329,8 @@ cluster_corrupt_out: 
	/*

	 * Unlocks the flush lock

	 */

	xfs_iflush_abort(iq, false);

	kmem_free(ilist);

	xfs_iflush_abort(cip, false);

	kmem_free(cilist);

	xfs_perag_put(pag);

	return -EFSCORRUPTED;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE