Commit 1929e82e authored Mar 08, 2018 by Stephen Kitt Committed by Martin K. Petersen Mar 15, 2018

scsi: bfa: remove VLA

In preparation to enabling -Wvla, remove VLAs and replace them with
fixed-length arrays instead.

bfad_bsg.c uses a variable-length array declaration to measure the
size of a putative array; this can be replaced by the product of the
size of an element and the number of elements, avoiding the VLA
altogether.

This was prompted by https://lkml.org/lkml/2018/3/7/621



Signed-off-by: Stephen Kitt <steve@sk2.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 88b13609

drivers/scsi/bfa/bfad_bsg.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -891,7 +891,7 @@ bfad_iocmd_fabric_get_lports(struct bfad_s bfad, void cmd,

		if (bfad_chk_iocmd_sz(payload_len,
		sizeof(struct bfa_bsg_fabric_get_lports_s),
		sizeof(wwn_t[iocmd->nports])) != BFA_STATUS_OK) {
		sizeof(wwn_t) * iocmd->nports) != BFA_STATUS_OK) {
		iocmd->status = BFA_STATUS_VERSION_FAIL;
		goto out;
		}

Admin message