Commit 19279235 authored Jul 14, 2017 by Carolyn Wyborny Committed by Jeff Kirsher Aug 27, 2017

i40e: Fix for unused value issue found by static analysis



This patch fixes an issue where an error return value is
set, but without an immediate exit, the value can be overwritten
by the following code execution.  The condition  at this point
is not fatal, so remove the error assignment and comment the
intent for future code maintainers

Signed-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 68e49702

drivers/net/ethernet/intel/i40e/i40e_main.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -9884,13 +9884,15 @@ static int i40e_add_vsi(struct i40e_vsi *vsi)
		*/
		ret = i40e_vsi_config_tc(vsi, enabled_tc);
		if (ret) {
		/* Single TC condition is not fatal,
		* message and continue
		*/
		dev_info(&pf->pdev->dev,
		"failed to configure TCs for main VSI tc_map 0x%08x, err %s aq_err %s\n",
		enabled_tc,
		i40e_stat_str(&pf->hw, ret),
		i40e_aq_str(&pf->hw,
		pf->hw.aq.asq_last_status));
		ret = -ENOENT;
		}
		}
		break;

Admin message