Commit 19234c08 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

PM: Add missing syscore_suspend() and syscore_resume() calls 



Device suspend/resume infrastructure is used not only by the suspend
and hibernate code in kernel/power, but also by APM, Xen and the
kexec jump feature.  However, commit 40dc166c
(PM / Core: Introduce struct syscore_ops for core subsystems PM)
failed to add syscore_suspend() and syscore_resume() calls to that
code, which generally leads to breakage when the features in question
are used.

To fix this problem, add the missing syscore_suspend() and
syscore_resume() calls to arch/x86/kernel/apm_32.c, kernel/kexec.c
and drivers/xen/manage.c.

Signed-off-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
Acked-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
Acked-by: default avatarIan Campbell <ian.campbell@citrix.com>
parent 2ca6f62f

arch/x86/kernel/apm_32.c

+5 −0
Original line number Diff line number Diff line
@@ -228,6 +228,7 @@ 
#include <linux/kthread.h>

#include <linux/jiffies.h>

#include <linux/acpi.h>

#include <linux/syscore_ops.h>



#include <asm/system.h>

#include <asm/uaccess.h>
@@ -1238,6 +1239,7 @@ static int suspend(int vetoable) 


	local_irq_disable();

	sysdev_suspend(PMSG_SUSPEND);

	syscore_suspend();



	local_irq_enable();
@@ -1255,6 +1257,7 @@ static int suspend(int vetoable) 
		apm_error("suspend", err);

	err = (err == APM_SUCCESS) ? 0 : -EIO;



	syscore_resume();

	sysdev_resume();

	local_irq_enable();
@@ -1280,6 +1283,7 @@ static void standby(void) 


	local_irq_disable();

	sysdev_suspend(PMSG_SUSPEND);

	syscore_suspend();

	local_irq_enable();



	err = set_system_power_state(APM_STATE_STANDBY);
@@ -1287,6 +1291,7 @@ static void standby(void) 
		apm_error("standby", err);



	local_irq_disable();

	syscore_resume();

	sysdev_resume();

	local_irq_enable();

drivers/base/syscore.c

+2 −0
Original line number Diff line number Diff line
@@ -73,6 +73,7 @@ int syscore_suspend(void) 


	return ret;

}

EXPORT_SYMBOL_GPL(syscore_suspend);



/**

 * syscore_resume - Execute all the registered system core resume callbacks.
@@ -95,6 +96,7 @@ void syscore_resume(void) 
				"Interrupts enabled after %pF\n", ops->resume);

		}

}

EXPORT_SYMBOL_GPL(syscore_resume);

#endif /* CONFIG_PM_SLEEP */



/**

drivers/xen/manage.c

+8 −1
Original line number Diff line number Diff line
@@ -8,6 +8,7 @@ 
#include <linux/sysrq.h>

#include <linux/stop_machine.h>

#include <linux/freezer.h>

#include <linux/syscore_ops.h>



#include <xen/xen.h>

#include <xen/xenbus.h>
@@ -70,8 +71,13 @@ static int xen_suspend(void *data) 
	BUG_ON(!irqs_disabled());



	err = sysdev_suspend(PMSG_FREEZE);

	if (!err) {

		err = syscore_suspend();

		if (err)

			sysdev_resume();

	}

	if (err) {

		printk(KERN_ERR "xen_suspend: sysdev_suspend failed: %d\n",

		printk(KERN_ERR "xen_suspend: system core suspend failed: %d\n",

			err);

		return err;

	}
@@ -95,6 +101,7 @@ static int xen_suspend(void *data) 
		xen_timer_resume();

	}



	syscore_resume();

	sysdev_resume();



	return 0;

kernel/kexec.c

+7 −0
Original line number Diff line number Diff line
@@ -33,6 +33,7 @@ 
#include <linux/vmalloc.h>

#include <linux/swap.h>

#include <linux/kmsg_dump.h>

#include <linux/syscore_ops.h>



#include <asm/page.h>

#include <asm/uaccess.h>
@@ -1532,6 +1533,11 @@ int kernel_kexec(void) 
		local_irq_disable();

		/* Suspend system devices */

		error = sysdev_suspend(PMSG_FREEZE);

		if (!error) {

			error = syscore_suspend();

			if (error)

				sysdev_resume();

		}

		if (error)

			goto Enable_irqs;

	} else
@@ -1546,6 +1552,7 @@ int kernel_kexec(void) 


#ifdef CONFIG_KEXEC_JUMP

	if (kexec_image->preserve_context) {

		syscore_resume();

		sysdev_resume();

 Enable_irqs:

		local_irq_enable();

CRA Git | Maintained and supported by SUSTech CRA and CCSE